leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #1299

New Issue
Closed
opened 2026-03-30 10:24:57 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-30 10:24:57 +00:00
Owner
Copy Link
Copy Source

Summary

There is no linting or type checking in CI. Style violations and type errors can accumulate undetected.

Work to do

  • Add a lint job to CI that runs ruff check . on the Python backend.
  • Add a step or separate job that runs tsc --noEmit on the TypeScript frontend.
  • Both checks should fail the pipeline on any errors.
  • Add ruff to the Python dev dependencies (e.g., requirements-dev.txt) and ensure it has a config section in pyproject.toml or ruff.toml.
  • Fix any pre-existing lint/type errors introduced by this change before merging.

Acceptance criteria

  • ruff check . runs in CI and fails on Python lint errors.
  • tsc --noEmit runs in CI and fails on TypeScript type errors.
  • The codebase passes both checks after initial fixes are applied.

References

Roadmap: P2 CI/CD — No linting or type checking.

## Summary There is no linting or type checking in CI. Style violations and type errors can accumulate undetected. ## Work to do - Add a `lint` job to CI that runs `ruff check .` on the Python backend. - Add a step or separate job that runs `tsc --noEmit` on the TypeScript frontend. - Both checks should fail the pipeline on any errors. - Add `ruff` to the Python dev dependencies (e.g., `requirements-dev.txt`) and ensure it has a config section in `pyproject.toml` or `ruff.toml`. - Fix any pre-existing lint/type errors introduced by this change before merging. ## Acceptance criteria - `ruff check .` runs in CI and fails on Python lint errors. - `tsc --noEmit` runs in CI and fails on TypeScript type errors. - The codebase passes both checks after initial fixes are applied. ## References Roadmap: P2 CI/CD — No linting or type checking.
AI-Manager added the P2agent-readymediumci labels 2026-03-30 10:24:57 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-30 11:03:56 +00:00
AI-Manager commented 2026-03-30 11:05:11 +00:00
Author
Owner
Copy Link
Copy Source

Triaged by @AI-Manager. Priority: P2. Assigned to @AI-Engineer (devops). Add linting to CI.

Triaged by @AI-Manager. Priority: P2. Assigned to @AI-Engineer (devops). Add linting to CI.
AI-Manager commented 2026-03-30 11:09:15 +00:00
Author
Owner
Copy Link
Copy Source

Already resolved. CI test job runs ruff check SPARC/ tests/ (line 34) and npx tsc --noEmit (line 48). Both fail the pipeline on errors. ruff.toml exists at repo root. PR #269 (commit 2bbf2d7) added tsc checking. Closing.

Already resolved. CI test job runs `ruff check SPARC/ tests/` (line 34) and `npx tsc --noEmit` (line 48). Both fail the pipeline on errors. `ruff.toml` exists at repo root. PR #269 (commit 2bbf2d7) added tsc checking. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready ci medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1299
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?