leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Security: refuse to start with default JWT secret in non-development environments #1309

New Issue
Closed
opened 2026-03-30 11:21:56 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 11:21:56 +00:00
Owner
Copy Link
Copy Source

Background

auth.py ships a fallback sparc-secret-key-change-in-production value that will be used if JWT_SECRET is unset. This is a critical security risk if the application is accidentally deployed to production without setting the secret.

What to do

  • In auth.py (or startup/lifespan code), read the JWT_SECRET environment variable.
  • If the value equals the default sparc-secret-key-change-in-production AND the ENVIRONMENT (or APP_ENV) variable is not development, raise a clear RuntimeError that prevents the application from starting.
  • Add a note in .env.example / documentation explaining the requirement.

Acceptance criteria

  • pytest passes with APP_ENV=development and the default secret.
  • Starting the app in any other env with the default secret logs a clear fatal error and exits non-zero.
  • No regression in existing auth tests.

References

Roadmap: P1 Security hardening — Rotate default JWT secret.

## Background `auth.py` ships a fallback `sparc-secret-key-change-in-production` value that will be used if `JWT_SECRET` is unset. This is a critical security risk if the application is accidentally deployed to production without setting the secret. ## What to do - In `auth.py` (or startup/lifespan code), read the `JWT_SECRET` environment variable. - If the value equals the default `sparc-secret-key-change-in-production` AND the `ENVIRONMENT` (or `APP_ENV`) variable is not `development`, raise a clear `RuntimeError` that prevents the application from starting. - Add a note in `.env.example` / documentation explaining the requirement. ## Acceptance criteria - `pytest` passes with `APP_ENV=development` and the default secret. - Starting the app in any other env with the default secret logs a clear fatal error and exits non-zero. - No regression in existing auth tests. ## References Roadmap: P1 Security hardening — Rotate default JWT secret.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-30 11:21:57 +00:00
AI-Manager commented 2026-03-30 12:03:52 +00:00
Author
Owner
Copy Link
Copy Source

Already resolved. check_jwt_secret() in SPARC/auth.py raises RuntimeError when JWT_SECRET is the default value and APP_ENV != development. Called at startup in api.py lifespan. Tests in tests/test_security.py.

Already resolved. `check_jwt_secret()` in `SPARC/auth.py` raises `RuntimeError` when `JWT_SECRET` is the default value and `APP_ENV != development`. Called at startup in `api.py` lifespan. Tests in `tests/test_security.py`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1309
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?