leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refuse startup with default JWT secret in non-development environments #131

New Issue
Closed
opened 2026-03-26 17:21:24 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 17:21:24 +00:00
Owner
Copy Link
Copy Source

Context

auth.py ships a fallback sparc-secret-key-change-in-production value used when JWT_SECRET is unset. Deploying to production with this default is a critical security risk.

Work

  • Add a startup check (e.g., in a FastAPI lifespan or startup event) that reads JWT_SECRET from the environment.
  • If JWT_SECRET equals the known default and ENVIRONMENT is not development, raise a RuntimeError and prevent the app from starting.
  • Document JWT_SECRET and ENVIRONMENT in .env.example.

Acceptance Criteria

  • App refuses to start when JWT_SECRET is the default value and ENVIRONMENT != development.
  • App starts normally in development with the default secret (warning log emitted).
  • App starts normally in production when a custom secret is set.
  • Unit test covers both the blocked and allowed paths.

References

Roadmap: P1 — Security hardening — Rotate default JWT secret.

## Context `auth.py` ships a fallback `sparc-secret-key-change-in-production` value used when `JWT_SECRET` is unset. Deploying to production with this default is a critical security risk. ## Work - Add a startup check (e.g., in a FastAPI `lifespan` or `startup` event) that reads `JWT_SECRET` from the environment. - If `JWT_SECRET` equals the known default and `ENVIRONMENT` is not `development`, raise a `RuntimeError` and prevent the app from starting. - Document `JWT_SECRET` and `ENVIRONMENT` in `.env.example`. ## Acceptance Criteria - App refuses to start when `JWT_SECRET` is the default value and `ENVIRONMENT != development`. - App starts normally in development with the default secret (warning log emitted). - App starts normally in production when a custom secret is set. - Unit test covers both the blocked and allowed paths. ## References Roadmap: P1 — Security hardening — Rotate default JWT secret.
AI-Manager added the P1agent-readysmall labels 2026-03-26 17:21:24 +00:00
AI-Manager commented 2026-03-26 18:03:56 +00:00
Author
Owner
Copy Link
Copy Source

Closing: auth.py includes enforce_jwt_secret() which raises RuntimeError if the default JWT secret is used in non-development environments. Resolved.

Closing: auth.py includes enforce_jwt_secret() which raises RuntimeError if the default JWT secret is used in non-development environments. Resolved.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#131
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?