leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Security: make CORS allowed origins configurable via environment variable #1310

New Issue
Closed
opened 2026-03-30 11:22:10 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 11:22:10 +00:00
Owner
Copy Link
Copy Source

Background

api.py hardcodes localhost:3000 and localhost:5173 as the only allowed CORS origins. This means the dashboard cannot function when deployed behind a real domain without a code change.

What to do

  • Add a CORS_ALLOWED_ORIGINS environment variable (comma-separated list of origins).
  • In api.py, parse this variable and pass the result to the CORS middleware.
  • Fall back to the current localhost defaults only when the variable is absent.
  • Update .env.example with the new variable.

Acceptance criteria

  • Setting CORS_ALLOWED_ORIGINS=https://sparc.example.com causes the API to return that origin in Access-Control-Allow-Origin headers.
  • No CORS regression for the existing local-dev defaults.
  • Unit test (or integration test) verifying origin allowlist is read from env.

References

Roadmap: P1 Security hardening — CORS allow-origins are hardcoded.

## Background `api.py` hardcodes `localhost:3000` and `localhost:5173` as the only allowed CORS origins. This means the dashboard cannot function when deployed behind a real domain without a code change. ## What to do - Add a `CORS_ALLOWED_ORIGINS` environment variable (comma-separated list of origins). - In `api.py`, parse this variable and pass the result to the CORS middleware. - Fall back to the current localhost defaults only when the variable is absent. - Update `.env.example` with the new variable. ## Acceptance criteria - Setting `CORS_ALLOWED_ORIGINS=https://sparc.example.com` causes the API to return that origin in `Access-Control-Allow-Origin` headers. - No CORS regression for the existing local-dev defaults. - Unit test (or integration test) verifying origin allowlist is read from env. ## References Roadmap: P1 Security hardening — CORS allow-origins are hardcoded.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-30 11:22:10 +00:00
AI-Manager commented 2026-03-30 12:03:54 +00:00
Author
Owner
Copy Link
Copy Source

Already resolved. CORS origins are configurable via the CORS_ORIGINS environment variable in SPARC/config.py (lines 63-70). The API middleware in api.py uses config.cors_origins. Tests in tests/test_security.py.

Already resolved. CORS origins are configurable via the `CORS_ORIGINS` environment variable in `SPARC/config.py` (lines 63-70). The API middleware in `api.py` uses `config.cors_origins`. Tests in `tests/test_security.py`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1310
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?