leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix: share a single pooled DatabaseClient instead of creating one per request in auth.py #1312

New Issue
Closed
opened 2026-03-30 11:22:35 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 11:22:35 +00:00
Owner
Copy Link
Copy Source

Background

get_db_client() in auth.py instantiates a new DatabaseClient on every call. This bypasses the connection pool and can exhaust the PostgreSQL max_connections limit under even moderate load.

What to do

  • Refactor get_db_client() to return a module-level (or application-lifespan-scoped) singleton DatabaseClient.
  • Ensure the singleton is initialized once at startup and properly closed on shutdown.
  • If FastAPI dependency injection is used elsewhere to provide a DB client, align auth.py with that pattern.

Acceptance criteria

  • A single DatabaseClient instance is shared across all requests handled by auth.py.
  • Under a load test (e.g., 50 concurrent login requests), PostgreSQL connection count does not grow unboundedly.
  • All existing auth-related tests continue to pass.

References

Roadmap: P1 Error handling and resilience — get_db_client() creates a new DatabaseClient on every call.

## Background `get_db_client()` in `auth.py` instantiates a new `DatabaseClient` on every call. This bypasses the connection pool and can exhaust the PostgreSQL `max_connections` limit under even moderate load. ## What to do - Refactor `get_db_client()` to return a module-level (or application-lifespan-scoped) singleton `DatabaseClient`. - Ensure the singleton is initialized once at startup and properly closed on shutdown. - If FastAPI dependency injection is used elsewhere to provide a DB client, align `auth.py` with that pattern. ## Acceptance criteria - A single `DatabaseClient` instance is shared across all requests handled by `auth.py`. - Under a load test (e.g., 50 concurrent login requests), PostgreSQL connection count does not grow unboundedly. - All existing auth-related tests continue to pass. ## References Roadmap: P1 Error handling and resilience — get_db_client() creates a new DatabaseClient on every call.
AI-Manager added the P1agent-readysmallrefactor labels 2026-03-30 11:22:35 +00:00
AI-Manager commented 2026-03-30 12:03:59 +00:00
Author
Owner
Copy Link
Copy Source

Already resolved. SPARC/auth.py uses a module-level singleton _db_client with init_db_client()/close_db_client()/get_db_client(). DatabaseClient in database.py uses psycopg2.pool.ThreadedConnectionPool (min 2, max 10 connections).

Already resolved. `SPARC/auth.py` uses a module-level singleton `_db_client` with `init_db_client()`/`close_db_client()`/`get_db_client()`. `DatabaseClient` in `database.py` uses `psycopg2.pool.ThreadedConnectionPool` (min 2, max 10 connections).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready refactor small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1312
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?