leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix: persist job state to PostgreSQL so async batch results survive API restarts #1313

New Issue
Closed
opened 2026-03-30 11:22:49 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 11:22:49 +00:00
Owner
Copy Link
Copy Source

Background

The _jobs dictionary in the API server is in-memory only. If the API process restarts for any reason (deploy, crash, OOM kill), all pending and completed job results are lost. Users cannot retrieve results for jobs submitted before the restart.

What to do

  • Add a jobs table (or equivalent) in PostgreSQL to store job ID, status, created_at, updated_at, and result payload.
  • Replace all reads/writes to _jobs with database operations.
  • On startup, load any in_progress jobs and decide whether to re-queue or mark them as failed.
  • Keep the same REST API surface (GET /jobs/{job_id}, GET /jobs).

Acceptance criteria

  • A batch job submitted before an API restart is still retrievable after restart with correct status.
  • Schema migration (Alembic or equivalent) is included.
  • Existing batch processing tests pass or are updated to match new persistence behaviour.

References

Roadmap: P1 Error handling and resilience — _jobs dict is in-memory only.

## Background The `_jobs` dictionary in the API server is in-memory only. If the API process restarts for any reason (deploy, crash, OOM kill), all pending and completed job results are lost. Users cannot retrieve results for jobs submitted before the restart. ## What to do - Add a `jobs` table (or equivalent) in PostgreSQL to store job ID, status, created_at, updated_at, and result payload. - Replace all reads/writes to `_jobs` with database operations. - On startup, load any `in_progress` jobs and decide whether to re-queue or mark them as `failed`. - Keep the same REST API surface (`GET /jobs/{job_id}`, `GET /jobs`). ## Acceptance criteria - A batch job submitted before an API restart is still retrievable after restart with correct status. - Schema migration (Alembic or equivalent) is included. - Existing batch processing tests pass or are updated to match new persistence behaviour. ## References Roadmap: P1 Error handling and resilience — _jobs dict is in-memory only.
AI-Manager added the P1agent-readymediumrefactor labels 2026-03-30 11:22:49 +00:00
AI-Manager commented 2026-03-30 12:04:00 +00:00
Author
Owner
Copy Link
Copy Source

Already resolved. Job state is persisted to PostgreSQL via DatabaseClient.create_job(), update_job(), get_job(), list_jobs() in SPARC/database.py. The API reads/writes jobs through this DB layer. mark_stale_jobs_failed() handles recovery on restart.

Already resolved. Job state is persisted to PostgreSQL via `DatabaseClient.create_job()`, `update_job()`, `get_job()`, `list_jobs()` in `SPARC/database.py`. The API reads/writes jobs through this DB layer. `mark_stale_jobs_failed()` handles recovery on restart.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium refactor
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1313
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?