leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Security: add rate limiting to /auth/login and /auth/register endpoints #1314

New Issue
Closed
opened 2026-03-30 11:23:00 +00:00 by AI-Manager · 0 comments
AI-Manager commented 2026-03-30 11:23:00 +00:00
Owner
Copy Link
Copy Source

Background

/auth/login and /auth/register have no protection against brute-force attacks or credential-stuffing abuse. An attacker can make unlimited attempts without any throttling.

What to do

  • Add a rate-limiting middleware or per-route limiter (e.g., slowapi for FastAPI).
  • Apply a sensible limit to /auth/login (e.g., 10 requests/minute per IP) and /auth/register (e.g., 5 requests/minute per IP).
  • Return HTTP 429 with a Retry-After header when the limit is exceeded.
  • Make limits configurable via environment variables.

Acceptance criteria

  • Exceeding the configured rate limit on /auth/login returns 429.
  • Requests within the limit succeed normally.
  • Rate-limit configuration (thresholds and window) can be changed via env vars without code changes.
  • Tests verify 429 is returned after threshold is crossed.

References

Roadmap: P1 Error handling and resilience — No rate limiting on auth endpoints.

## Background `/auth/login` and `/auth/register` have no protection against brute-force attacks or credential-stuffing abuse. An attacker can make unlimited attempts without any throttling. ## What to do - Add a rate-limiting middleware or per-route limiter (e.g., `slowapi` for FastAPI). - Apply a sensible limit to `/auth/login` (e.g., 10 requests/minute per IP) and `/auth/register` (e.g., 5 requests/minute per IP). - Return HTTP 429 with a `Retry-After` header when the limit is exceeded. - Make limits configurable via environment variables. ## Acceptance criteria - Exceeding the configured rate limit on `/auth/login` returns 429. - Requests within the limit succeed normally. - Rate-limit configuration (thresholds and window) can be changed via env vars without code changes. - Tests verify 429 is returned after threshold is crossed. ## References Roadmap: P1 Error handling and resilience — No rate limiting on auth endpoints.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-30 11:23:00 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1314
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?