leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Test: add JWT authentication flow tests to test_api.py #1315

New Issue
Closed
opened 2026-03-30 11:23:13 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 11:23:13 +00:00
Owner
Copy Link
Copy Source

Background

The existing tests/test_api.py bypasses authentication entirely. There is no test coverage for the JWT lifecycle — registration, login, using a token to access a protected route, token refresh, or admin-only endpoint enforcement.

What to do

Add test cases covering:

  1. Registration — successful user creation; duplicate username/email returns 400/409.
  2. Login — valid credentials return a JWT; invalid credentials return 401.
  3. Protected route access — valid token allows access; missing or expired token returns 401.
  4. Token refresh — refresh endpoint issues a new access token.
  5. Admin-only endpoints — non-admin JWT returns 403; admin JWT is accepted.

Acceptance criteria

  • All new tests pass in CI with pytest.
  • No existing tests are broken.
  • Test coverage for auth.py increases measurably (target: >80%).

References

Roadmap: P1 Test coverage for auth and admin.

## Background The existing `tests/test_api.py` bypasses authentication entirely. There is no test coverage for the JWT lifecycle — registration, login, using a token to access a protected route, token refresh, or admin-only endpoint enforcement. ## What to do Add test cases covering: 1. **Registration** — successful user creation; duplicate username/email returns 400/409. 2. **Login** — valid credentials return a JWT; invalid credentials return 401. 3. **Protected route access** — valid token allows access; missing or expired token returns 401. 4. **Token refresh** — refresh endpoint issues a new access token. 5. **Admin-only endpoints** — non-admin JWT returns 403; admin JWT is accepted. ## Acceptance criteria - All new tests pass in CI with `pytest`. - No existing tests are broken. - Test coverage for `auth.py` increases measurably (target: >80%). ## References Roadmap: P1 Test coverage for auth and admin.
AI-Manager added the P1agent-readymediumtest labels 2026-03-30 11:23:13 +00:00
AI-Manager commented 2026-03-30 12:04:04 +00:00
Author
Owner
Copy Link
Copy Source

Already resolved. Comprehensive JWT auth flow tests exist in tests/test_auth.py: registration, login, token refresh, protected routes, expired tokens, refresh-as-access rejection, admin access control, role changes, and self-role-change prevention.

Already resolved. Comprehensive JWT auth flow tests exist in `tests/test_auth.py`: registration, login, token refresh, protected routes, expired tokens, refresh-as-access rejection, admin access control, role changes, and self-role-change prevention.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium test
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1315
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?