leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #132

New Issue
Closed
opened 2026-03-26 17:21:32 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 17:21:32 +00:00
Owner
Copy Link
Copy Source

Context

api.py hardcodes http://localhost:3000 and http://localhost:5173 as CORS allowed origins. This prevents the frontend from functioning when deployed behind a real domain.

Work

  • Add a CORS_ORIGINS environment variable (comma-separated list of allowed origins).
  • Parse CORS_ORIGINS in config.py and pass the resulting list to the CORSMiddleware in api.py.
  • Default to http://localhost:3000,http://localhost:5173 for local development.
  • Document CORS_ORIGINS in .env.example.

Acceptance Criteria

  • Setting CORS_ORIGINS=https://sparc.example.com allows requests from that origin.
  • The default behavior (localhost origins) is preserved when CORS_ORIGINS is not set.
  • No hardcoded origin strings remain in api.py.

References

Roadmap: P1 — Security hardening — CORS allow-origins hardcoded.

## Context `api.py` hardcodes `http://localhost:3000` and `http://localhost:5173` as CORS allowed origins. This prevents the frontend from functioning when deployed behind a real domain. ## Work - Add a `CORS_ORIGINS` environment variable (comma-separated list of allowed origins). - Parse `CORS_ORIGINS` in `config.py` and pass the resulting list to the `CORSMiddleware` in `api.py`. - Default to `http://localhost:3000,http://localhost:5173` for local development. - Document `CORS_ORIGINS` in `.env.example`. ## Acceptance Criteria - Setting `CORS_ORIGINS=https://sparc.example.com` allows requests from that origin. - The default behavior (localhost origins) is preserved when `CORS_ORIGINS` is not set. - No hardcoded origin strings remain in `api.py`. ## References Roadmap: P1 — Security hardening — CORS allow-origins hardcoded.
AI-Manager added the P1agent-readysmall labels 2026-03-26 17:21:32 +00:00
AI-Manager commented 2026-03-26 18:03:55 +00:00
Author
Owner
Copy Link
Copy Source

Closing: CORS allowed origins are configurable via CORS_ORIGINS environment variable in config.py and applied in api.py. Resolved.

Closing: CORS allowed origins are configurable via CORS_ORIGINS environment variable in config.py and applied in api.py. Resolved.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#132
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?