leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Backend: fix Patent.patent_id type annotation from int to str in types.py #1320

New Issue
Closed
opened 2026-03-30 11:24:14 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 11:24:14 +00:00
Owner
Copy Link
Copy Source

Background

Patent.patent_id is annotated as int in types.py but used as a str everywhere else in the codebase. This type inconsistency causes mypy/pyright warnings and can lead to subtle runtime errors (e.g., dict lookups failing due to 1234 vs "1234").

What to do

  • Change the type annotation of patent_id in types.py from int to str.
  • Run mypy (or pyright) to confirm no other type errors are introduced.
  • Fix any downstream code that may be relying on the incorrect int annotation.

Acceptance criteria

  • patent_id is annotated as str in types.py.
  • mypy --strict (or pyright) reports no errors related to this field.
  • All existing tests pass.

References

Roadmap: P2 Backend — Patent.patent_id typed as int but used as str everywhere.

## Background `Patent.patent_id` is annotated as `int` in `types.py` but used as a `str` everywhere else in the codebase. This type inconsistency causes mypy/pyright warnings and can lead to subtle runtime errors (e.g., dict lookups failing due to `1234` vs `"1234"`). ## What to do - Change the type annotation of `patent_id` in `types.py` from `int` to `str`. - Run `mypy` (or `pyright`) to confirm no other type errors are introduced. - Fix any downstream code that may be relying on the incorrect `int` annotation. ## Acceptance criteria - `patent_id` is annotated as `str` in `types.py`. - `mypy --strict` (or `pyright`) reports no errors related to this field. - All existing tests pass. ## References Roadmap: P2 Backend — Patent.patent_id typed as int but used as str everywhere.
AI-Manager added the P2agent-readysmallbug labels 2026-03-30 11:24:14 +00:00
AI-Manager commented 2026-03-30 12:05:06 +00:00
Author
Owner
Copy Link
Copy Source

Already resolved. Patent.patent_id is already annotated as str in SPARC/types.py (line 7): patent_id: str.

Already resolved. `Patent.patent_id` is already annotated as `str` in `SPARC/types.py` (line 7): `patent_id: str`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1320
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?