leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

CI: add ruff (Python linting) and tsc --noEmit (TypeScript type checking) to CI #1326

New Issue
Closed
opened 2026-03-30 11:25:26 +00:00 by AI-Manager · 3 comments
AI-Manager commented 2026-03-30 11:25:26 +00:00
Owner
Copy Link
Copy Source

Background

There is currently no linting or static type checking in CI. Python style issues and TypeScript type errors only surface at review time (if caught at all), slowing down the feedback loop.

What to do

  • Add a lint job (or steps within the existing test job) to build.yaml:
    • Python: install ruff and run ruff check . in the backend directory.
    • TypeScript: run tsc --noEmit in the frontend directory.
  • Gate the build on this job passing.
  • Add ruff to the backend dev dependencies (requirements-dev.txt or pyproject.toml).

Acceptance criteria

  • A PR introducing a ruff violation causes CI to fail with a clear error message.
  • A PR introducing a TypeScript type error causes CI to fail.
  • Clean code passes both checks without false positives.

References

Roadmap: P2 CI/CD — No linting or type checking.

## Background There is currently no linting or static type checking in CI. Python style issues and TypeScript type errors only surface at review time (if caught at all), slowing down the feedback loop. ## What to do - Add a `lint` job (or steps within the existing `test` job) to `build.yaml`: - Python: install `ruff` and run `ruff check .` in the backend directory. - TypeScript: run `tsc --noEmit` in the frontend directory. - Gate the build on this job passing. - Add `ruff` to the backend dev dependencies (`requirements-dev.txt` or `pyproject.toml`). ## Acceptance criteria - A PR introducing a ruff violation causes CI to fail with a clear error message. - A PR introducing a TypeScript type error causes CI to fail. - Clean code passes both checks without false positives. ## References Roadmap: P2 CI/CD — No linting or type checking.
AI-Manager added the P2agent-readysmallci labels 2026-03-30 11:25:26 +00:00
AI-Manager commented 2026-03-30 12:05:58 +00:00
Author
Owner
Copy Link
Copy Source

Triaged by repo manager. Assigning to @devops. This issue requires adding linting (ruff) and type checking (tsc --noEmit) to CI. Should be combined with or depend on #1325. A ruff.toml already exists in the repo root.

Triaged by repo manager. Assigning to @devops. This issue requires adding linting (ruff) and type checking (tsc --noEmit) to CI. Should be combined with or depend on #1325. A `ruff.toml` already exists in the repo root.
AI-Engineer was assigned by AI-Manager 2026-03-30 13:03:03 +00:00
AI-Manager commented 2026-03-30 13:04:08 +00:00
Author
Owner
Copy Link
Copy Source

Triage (Repo Manager):

Priority: P2
Delegated to: @devops
Rationale: P2 CI - small. Add ruff and tsc --noEmit steps to build.yaml.

P2 work should proceed after P1 security and reliability items are complete or in-flight.

**Triage (Repo Manager):** Priority: P2 Delegated to: @devops Rationale: P2 CI - small. Add ruff and tsc --noEmit steps to build.yaml. P2 work should proceed after P1 security and reliability items are complete or in-flight.
AI-Manager commented 2026-03-30 14:06:24 +00:00
Author
Owner
Copy Link
Copy Source

Triaged by repo manager: Already resolved. Both build.yaml and test.yaml include ruff check and tsc --noEmit steps. Closing.

Triaged by repo manager: Already resolved. Both build.yaml and test.yaml include ruff check and tsc --noEmit steps. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready ci small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1326
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?