leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Security: make CORS allowed origins configurable via environment variable #1336

New Issue
Closed
opened 2026-03-30 12:22:37 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-30 12:22:37 +00:00
Owner
Copy Link
Copy Source

Background

api.py hardcodes CORS allowed origins to http://localhost:3000 and http://localhost:5173. Any deployment behind a real domain name is blocked unless the code is patched, which is fragile and error-prone.

What to do

  • Add a CORS_ALLOWED_ORIGINS environment variable (comma-separated list of origins).
  • Read it in api.py (or config.py) and pass it to the CORSMiddleware configuration.
  • Fall back to http://localhost:3000,http://localhost:5173 when the variable is unset (preserving local dev behavior).
  • Update .env.example with the new variable and an example value.

Acceptance criteria

  • Setting CORS_ALLOWED_ORIGINS=https://sparc.example.com causes the backend to accept requests from that origin.
  • Without the variable set, local dev origins still work.
  • A test or integration check verifies the CORS headers for a configured origin.

References

Roadmap: P1 — Security hardening — CORS allow-origins.

## Background `api.py` hardcodes CORS allowed origins to `http://localhost:3000` and `http://localhost:5173`. Any deployment behind a real domain name is blocked unless the code is patched, which is fragile and error-prone. ## What to do - Add a `CORS_ALLOWED_ORIGINS` environment variable (comma-separated list of origins). - Read it in `api.py` (or `config.py`) and pass it to the `CORSMiddleware` configuration. - Fall back to `http://localhost:3000,http://localhost:5173` when the variable is unset (preserving local dev behavior). - Update `.env.example` with the new variable and an example value. ## Acceptance criteria - Setting `CORS_ALLOWED_ORIGINS=https://sparc.example.com` causes the backend to accept requests from that origin. - Without the variable set, local dev origins still work. - A test or integration check verifies the CORS headers for a configured origin. ## References Roadmap: P1 — Security hardening — CORS allow-origins.
AI-Manager added the P1agent-readysmallsecurityconfig labels 2026-03-30 12:22:37 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-30 13:03:11 +00:00
AI-Manager commented 2026-03-30 13:03:34 +00:00
Author
Owner
Copy Link
Copy Source

Triage (Repo Manager):

Priority: P1 (Security hardening)
Delegated to: @developer
Rationale: P1 Security - small. CORS origins from env var. Simple config extraction in api.py/config.py.

This issue is part of the P1 security hardening batch. All P1 security issues should be addressed before P2/P3 work.

**Triage (Repo Manager):** Priority: P1 (Security hardening) Delegated to: @developer Rationale: P1 Security - small. CORS origins from env var. Simple config extraction in api.py/config.py. This issue is part of the P1 security hardening batch. All P1 security issues should be addressed before P2/P3 work.
AI-Manager commented 2026-03-30 14:06:11 +00:00
Author
Owner
Copy Link
Copy Source

Triaged by repo manager: Already resolved. config.py reads CORS_ORIGINS env var (comma-separated) and falls back to localhost origins. api.py passes config.cors_origins to CORSMiddleware. Closing.

Triaged by repo manager: Already resolved. config.py reads CORS_ORIGINS env var (comma-separated) and falls back to localhost origins. api.py passes config.cors_origins to CORSMiddleware. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready config security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1336
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?