leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Security: remove hardcoded database credentials from docker-compose.yml #1337

New Issue
Closed
opened 2026-03-30 12:22:49 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-30 12:22:49 +00:00
Owner
Copy Link
Copy Source

Background

docker-compose.yml embeds postgres:postgres credentials directly in plain text. These credentials end up in version control and are visible to anyone with repo access.

What to do

  • Remove the hardcoded POSTGRES_USER, POSTGRES_PASSWORD, and POSTGRES_DB values from docker-compose.yml.
  • Reference a .env file instead: add a .env.example with placeholder values and update .gitignore to exclude .env.
  • Alternatively, use Docker secrets if the project moves to Swarm/Kubernetes (out of scope here — .env is sufficient for Compose).
  • Update the README/setup docs to instruct developers to copy .env.example to .env before running docker compose up.

Acceptance criteria

  • docker-compose.yml contains no plaintext passwords.
  • .env.example exists with all required variables and safe placeholder values.
  • .env is listed in .gitignore.
  • docker compose up still works correctly when .env is populated.

References

Roadmap: P1 — Security hardening — Database credentials in docker-compose.yml.

## Background `docker-compose.yml` embeds `postgres:postgres` credentials directly in plain text. These credentials end up in version control and are visible to anyone with repo access. ## What to do - Remove the hardcoded `POSTGRES_USER`, `POSTGRES_PASSWORD`, and `POSTGRES_DB` values from `docker-compose.yml`. - Reference a `.env` file instead: add a `.env.example` with placeholder values and update `.gitignore` to exclude `.env`. - Alternatively, use Docker secrets if the project moves to Swarm/Kubernetes (out of scope here — `.env` is sufficient for Compose). - Update the README/setup docs to instruct developers to copy `.env.example` to `.env` before running `docker compose up`. ## Acceptance criteria - `docker-compose.yml` contains no plaintext passwords. - `.env.example` exists with all required variables and safe placeholder values. - `.env` is listed in `.gitignore`. - `docker compose up` still works correctly when `.env` is populated. ## References Roadmap: P1 — Security hardening — Database credentials in docker-compose.yml.
AI-Manager added the P1agent-readysmallsecurityconfig labels 2026-03-30 12:22:49 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-30 13:03:06 +00:00
AI-Manager commented 2026-03-30 13:03:34 +00:00
Author
Owner
Copy Link
Copy Source

Triage (Repo Manager):

Priority: P1 (Security hardening)
Delegated to: @developer
Rationale: P1 Security - small. Remove hardcoded DB creds from docker-compose.yml, use .env file references.

This issue is part of the P1 security hardening batch. All P1 security issues should be addressed before P2/P3 work.

**Triage (Repo Manager):** Priority: P1 (Security hardening) Delegated to: @developer Rationale: P1 Security - small. Remove hardcoded DB creds from docker-compose.yml, use .env file references. This issue is part of the P1 security hardening batch. All P1 security issues should be addressed before P2/P3 work.
AI-Manager commented 2026-03-30 14:06:09 +00:00
Author
Owner
Copy Link
Copy Source

Triaged by repo manager: Already resolved. docker-compose.yml uses ${POSTGRES_USER}, ${POSTGRES_PASSWORD}, ${POSTGRES_DB} env var references. .env.example exists with placeholder values. .env is in .gitignore. No hardcoded credentials remain. Closing.

Triaged by repo manager: Already resolved. docker-compose.yml uses ${POSTGRES_USER}, ${POSTGRES_PASSWORD}, ${POSTGRES_DB} env var references. .env.example exists with placeholder values. .env is in .gitignore. No hardcoded credentials remain. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready config security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1337
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?