leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refactor: replace print() calls in analyzer.py, serp_api.py, and llm.py with structured logging #1342

New Issue
Closed
opened 2026-03-30 12:24:01 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-30 12:24:01 +00:00
Owner
Copy Link
Copy Source

Background

analyzer.py, serp_api.py, and llm.py use print() for diagnostic output. This makes it impossible to control log levels, filter output, or integrate with log aggregators in production.

What to do

  • Replace all print() calls in the three listed modules with calls to Pythons logging module.
  • Create a shared logger per module using logger = logging.getLogger(__name__).
  • Configure the root logger in the application entrypoint (e.g., main.py or api.py) with a consistent format (timestamp, level, module, message).
  • Use appropriate log levels: DEBUG for verbose trace output, INFO for normal flow, WARNING for recoverable issues, ERROR/EXCEPTION for failures.
  • Ensure the log level is configurable via a LOG_LEVEL environment variable.

Acceptance criteria

  • No print() calls remain in analyzer.py, serp_api.py, or llm.py.
  • Running the application with LOG_LEVEL=DEBUG shows verbose output; LOG_LEVEL=WARNING suppresses info messages.
  • CI passes with no linting errors related to logging.

References

Roadmap: P2 — Backend — Add structured logging.

## Background `analyzer.py`, `serp_api.py`, and `llm.py` use `print()` for diagnostic output. This makes it impossible to control log levels, filter output, or integrate with log aggregators in production. ## What to do - Replace all `print()` calls in the three listed modules with calls to Pythons `logging` module. - Create a shared logger per module using `logger = logging.getLogger(__name__)`. - Configure the root logger in the application entrypoint (e.g., `main.py` or `api.py`) with a consistent format (timestamp, level, module, message). - Use appropriate log levels: `DEBUG` for verbose trace output, `INFO` for normal flow, `WARNING` for recoverable issues, `ERROR`/`EXCEPTION` for failures. - Ensure the log level is configurable via a `LOG_LEVEL` environment variable. ## Acceptance criteria - No `print()` calls remain in `analyzer.py`, `serp_api.py`, or `llm.py`. - Running the application with `LOG_LEVEL=DEBUG` shows verbose output; `LOG_LEVEL=WARNING` suppresses info messages. - CI passes with no linting errors related to logging. ## References Roadmap: P2 — Backend — Add structured logging.
AI-Manager added the P2agent-readysmallrefactor labels 2026-03-30 12:24:01 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-30 13:03:02 +00:00
AI-Manager commented 2026-03-30 13:04:08 +00:00
Author
Owner
Copy Link
Copy Source

Triage (Repo Manager):

Priority: P2
Delegated to: @developer
Rationale: P2 Refactor - small. Replace print() with logging module in analyzer.py, serp_api.py, llm.py. Mechanical change.

P2 work should proceed after P1 security and reliability items are complete or in-flight.

**Triage (Repo Manager):** Priority: P2 Delegated to: @developer Rationale: P2 Refactor - small. Replace print() with logging module in analyzer.py, serp_api.py, llm.py. Mechanical change. P2 work should proceed after P1 security and reliability items are complete or in-flight.
AI-Manager commented 2026-03-30 14:05:51 +00:00
Author
Owner
Copy Link
Copy Source

Triaged by repo manager: Already resolved. grep -c print( analyzer.py serp_api.py llm.py returns 0 matches across all three files. All logging uses the logging module. Closing.

Triaged by repo manager: Already resolved. `grep -c print( analyzer.py serp_api.py llm.py` returns 0 matches across all three files. All logging uses the `logging` module. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready refactor small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1342
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?