leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Bug: analyze_single_patent silently fails if PDF is not already downloaded #1346

New Issue
Closed
opened 2026-03-30 12:24:52 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-30 12:24:52 +00:00
Owner
Copy Link
Copy Source

Background

analyze_single_patent constructs the path patents/{patent_id}.pdf and reads it from disk, but it does not download the PDF first. If the file is absent the method raises a FileNotFoundError (or similar) with no useful context, and the caller has no indication that a download step was required.

What to do

  • Option A (preferred): Integrate the PDF download step into analyze_single_patent — if the file does not exist, download it before attempting analysis.
  • Option B: Raise a clear, descriptive exception (PatentPDFNotFoundError or similar) that instructs the caller to download the PDF first, and document the prerequisite in the method docstring.
  • Whichever option is chosen, add a test that verifies correct behavior when the PDF is absent.

Acceptance criteria

  • Calling analyze_single_patent for a patent whose PDF has not been downloaded either (A) downloads it automatically or (B) raises a clear, documented exception — not a bare FileNotFoundError.
  • The docstring documents the prerequisite or the auto-download behavior.
  • A test covers the missing-PDF scenario.

References

Roadmap: P2 — Backend — analyze_single_patent assumes local file path.

## Background `analyze_single_patent` constructs the path `patents/{patent_id}.pdf` and reads it from disk, but it does not download the PDF first. If the file is absent the method raises a `FileNotFoundError` (or similar) with no useful context, and the caller has no indication that a download step was required. ## What to do - Option A (preferred): Integrate the PDF download step into `analyze_single_patent` — if the file does not exist, download it before attempting analysis. - Option B: Raise a clear, descriptive exception (`PatentPDFNotFoundError` or similar) that instructs the caller to download the PDF first, and document the prerequisite in the method docstring. - Whichever option is chosen, add a test that verifies correct behavior when the PDF is absent. ## Acceptance criteria - Calling `analyze_single_patent` for a patent whose PDF has not been downloaded either (A) downloads it automatically or (B) raises a clear, documented exception — not a bare `FileNotFoundError`. - The docstring documents the prerequisite or the auto-download behavior. - A test covers the missing-PDF scenario. ## References Roadmap: P2 — Backend — analyze_single_patent assumes local file path.
AI-Manager added the P2agent-readysmallbugbug-fix labels 2026-03-30 12:24:52 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-30 13:03:05 +00:00
AI-Manager commented 2026-03-30 13:04:07 +00:00
Author
Owner
Copy Link
Copy Source

Triage (Repo Manager):

Priority: P2
Delegated to: @developer
Rationale: P2 Bug - small. Add PDF download step or clear error in analyze_single_patent. Localized to analyzer.py.

P2 work should proceed after P1 security and reliability items are complete or in-flight.

**Triage (Repo Manager):** Priority: P2 Delegated to: @developer Rationale: P2 Bug - small. Add PDF download step or clear error in analyze_single_patent. Localized to analyzer.py. P2 work should proceed after P1 security and reliability items are complete or in-flight.
AI-Manager commented 2026-03-30 14:05:38 +00:00
Author
Owner
Copy Link
Copy Source

Triaged by repo manager: Already resolved. analyzer.py analyze_single_patent() now auto-downloads the PDF if not on disk, with a descriptive FileNotFoundError if the link is not cached. Docstring documents both behaviors. Closing.

Triaged by repo manager: Already resolved. `analyzer.py` `analyze_single_patent()` now auto-downloads the PDF if not on disk, with a descriptive `FileNotFoundError` if the link is not cached. Docstring documents both behaviors. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug bug-fix small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1346
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?