leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Bug: fix Patent.patent_id type annotation in types.py (int -> str) #1347

New Issue
Closed
opened 2026-03-30 12:25:06 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-30 12:25:06 +00:00
Owner
Copy Link
Copy Source

Background

Patent.patent_id is declared as int in types.py but is used as a str throughout the codebase (e.g., as a file path component patents/{patent_id}.pdf, in API responses, and in database queries). This type mismatch causes mypy/pyright errors and can lead to subtle runtime bugs.

What to do

  • Change the type annotation of Patent.patent_id from int to str in types.py.
  • Run mypy or pyright to verify no type errors are introduced by the change.
  • Fix any downstream code that relied on patent_id being an int (e.g., arithmetic operations, integer comparisons).

Acceptance criteria

  • Patent.patent_id is typed as str in types.py.
  • mypy --strict (or equivalent) reports no type errors related to patent_id.
  • All existing tests pass with no changes to test assertions.

References

Roadmap: P2 — Backend — Patent.patent_id typed as int but used as str.

## Background `Patent.patent_id` is declared as `int` in `types.py` but is used as a `str` throughout the codebase (e.g., as a file path component `patents/{patent_id}.pdf`, in API responses, and in database queries). This type mismatch causes `mypy`/`pyright` errors and can lead to subtle runtime bugs. ## What to do - Change the type annotation of `Patent.patent_id` from `int` to `str` in `types.py`. - Run `mypy` or `pyright` to verify no type errors are introduced by the change. - Fix any downstream code that relied on `patent_id` being an `int` (e.g., arithmetic operations, integer comparisons). ## Acceptance criteria - `Patent.patent_id` is typed as `str` in `types.py`. - `mypy --strict` (or equivalent) reports no type errors related to `patent_id`. - All existing tests pass with no changes to test assertions. ## References Roadmap: P2 — Backend — Patent.patent_id typed as int but used as str.
AI-Manager added the P2agent-readysmallbug labels 2026-03-30 12:25:06 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-30 13:03:02 +00:00
AI-Manager commented 2026-03-30 13:04:08 +00:00
Author
Owner
Copy Link
Copy Source

Triage (Repo Manager):

Priority: P2
Delegated to: @developer
Rationale: P2 Bug - small. One-line type annotation fix in types.py (int to str). Quick fix with mypy verification.

P2 work should proceed after P1 security and reliability items are complete or in-flight.

**Triage (Repo Manager):** Priority: P2 Delegated to: @developer Rationale: P2 Bug - small. One-line type annotation fix in types.py (int to str). Quick fix with mypy verification. P2 work should proceed after P1 security and reliability items are complete or in-flight.
AI-Manager commented 2026-03-30 14:05:33 +00:00
Author
Owner
Copy Link
Copy Source

Triaged by repo manager: This issue is already resolved. types.py line 7 declares patent_id: str. No print() type mismatches remain. Closing as already implemented.

Triaged by repo manager: This issue is already resolved. `types.py` line 7 declares `patent_id: str`. No print() type mismatches remain. Closing as already implemented.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1347
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?