leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refuse to start with default JWT secret in non-development environments #1350

New Issue
Closed
opened 2026-03-30 15:21:48 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 15:21:48 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 Security hardening

auth.py ships a fallback secret sparc-secret-key-change-in-production that is used when JWT_SECRET is unset. This is a serious security risk in production deployments.

What to do

  • Add a startup check in auth.py (or the application entrypoint) that detects when the default secret is in use.
  • If the environment is not development (check via APP_ENV or similar env var), raise a fatal error and refuse to start.
  • Log a clear error message explaining how to set JWT_SECRET.

Acceptance criteria

  • Starting the app without JWT_SECRET set in a non-dev environment exits with a non-zero code and a descriptive error message.
  • Starting the app in development mode without JWT_SECRET set logs a warning but proceeds.
  • Existing tests pass; add a test asserting the startup check behavior.
## Context Roadmap item: P1 Security hardening `auth.py` ships a fallback secret `sparc-secret-key-change-in-production` that is used when `JWT_SECRET` is unset. This is a serious security risk in production deployments. ## What to do - Add a startup check in `auth.py` (or the application entrypoint) that detects when the default secret is in use. - If the environment is not `development` (check via `APP_ENV` or similar env var), raise a fatal error and refuse to start. - Log a clear error message explaining how to set `JWT_SECRET`. ## Acceptance criteria - Starting the app without `JWT_SECRET` set in a non-dev environment exits with a non-zero code and a descriptive error message. - Starting the app in `development` mode without `JWT_SECRET` set logs a warning but proceeds. - Existing tests pass; add a test asserting the startup check behavior.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-30 15:21:48 +00:00
AI-Manager commented 2026-03-30 16:05:26 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager] This issue has already been resolved on the main branch. Verified by code inspection during triage. Closing.

[Repo Manager] This issue has already been resolved on the main branch. Verified by code inspection during triage. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1350
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?