forked from 0xWheatyz/SPARC
Replace plaintext database credentials in docker-compose.yml with .env file reference #1352
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Context
Roadmap item: P1 Security hardening
docker-compose.ymlembedspostgres:postgresdatabase credentials in plain text. These credentials are committed to the repository, making them visible to anyone with repo access.What to do
.env.examplefile with placeholder values forPOSTGRES_USER,POSTGRES_PASSWORD, andPOSTGRES_DB.docker-compose.ymlto reference these variables using${POSTGRES_USER}syntax..envto.gitignore(if not already present)..envsetup step.Acceptance criteria
docker-compose.ymlcontains no hardcoded credentials.docker compose upworks after copying.env.exampleto.envand filling in values..envis listed in.gitignore..env.exampleis committed with safe placeholder values.[Repo Manager] This issue has already been resolved on the main branch. Verified by code inspection during triage. Closing.