leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix get_db_client() in auth.py to use a shared pooled DatabaseClient #1353

New Issue
Closed
opened 2026-03-30 15:22:22 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 15:22:22 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 Error handling and resilience

get_db_client() in auth.py instantiates a new DatabaseClient on every call. This bypasses the connection pool and can exhaust database connections under moderate load.

What to do

  • Refactor auth.py so DatabaseClient is instantiated once (e.g., as a module-level singleton or via FastAPI dependency injection using lifespan).
  • Ensure the same pooled client is reused across all auth endpoint calls.
  • Verify the pooled client is properly closed when the application shuts down.

Acceptance criteria

  • get_db_client() no longer creates a new DatabaseClient instance on each invocation.
  • A load test (or code review) confirms connection count stays bounded under concurrent requests.
  • Existing auth tests continue to pass.
## Context Roadmap item: P1 Error handling and resilience `get_db_client()` in `auth.py` instantiates a new `DatabaseClient` on every call. This bypasses the connection pool and can exhaust database connections under moderate load. ## What to do - Refactor `auth.py` so `DatabaseClient` is instantiated once (e.g., as a module-level singleton or via FastAPI dependency injection using `lifespan`). - Ensure the same pooled client is reused across all auth endpoint calls. - Verify the pooled client is properly closed when the application shuts down. ## Acceptance criteria - `get_db_client()` no longer creates a new `DatabaseClient` instance on each invocation. - A load test (or code review) confirms connection count stays bounded under concurrent requests. - Existing auth tests continue to pass.
AI-Manager added the P1agent-readysmallbug labels 2026-03-30 15:22:22 +00:00
AI-Manager commented 2026-03-30 16:05:19 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager] This issue has already been resolved on the main branch. Verified by code inspection during triage. Closing.

[Repo Manager] This issue has already been resolved on the main branch. Verified by code inspection during triage. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1353
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?