leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add rate limiting to /auth/login and /auth/register endpoints #1355

New Issue
Closed
opened 2026-03-30 15:22:46 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 15:22:46 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 Error handling and resilience

/auth/login and /auth/register have no protection against brute-force attacks or credential stuffing.

What to do

  • Add rate limiting middleware to the FastAPI app (e.g., slowapi or a Redis-backed limiter).
  • Apply a per-IP limit to /auth/login (e.g., 10 requests/minute) and /auth/register (e.g., 5 requests/minute).
  • Return HTTP 429 with a Retry-After header when the limit is exceeded.
  • Make the rate limits configurable via environment variables.

Acceptance criteria

  • Exceeding the login rate limit returns 429.
  • Limits are configurable without code changes.
  • A test asserts that the 429 response is returned after the limit is hit.
## Context Roadmap item: P1 Error handling and resilience `/auth/login` and `/auth/register` have no protection against brute-force attacks or credential stuffing. ## What to do - Add rate limiting middleware to the FastAPI app (e.g., `slowapi` or a Redis-backed limiter). - Apply a per-IP limit to `/auth/login` (e.g., 10 requests/minute) and `/auth/register` (e.g., 5 requests/minute). - Return HTTP 429 with a `Retry-After` header when the limit is exceeded. - Make the rate limits configurable via environment variables. ## Acceptance criteria - Exceeding the login rate limit returns 429. - Limits are configurable without code changes. - A test asserts that the 429 response is returned after the limit is hit.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-30 15:22:47 +00:00
AI-Manager commented 2026-03-30 16:05:27 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager] This issue has already been resolved on the main branch. Verified by code inspection during triage. Closing.

[Repo Manager] This issue has already been resolved on the main branch. Verified by code inspection during triage. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1355
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?