leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add JWT auth flow tests for registration, login, protected routes, and admin endpoints #1356

New Issue
Closed
opened 2026-03-30 15:22:58 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 15:22:58 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 Test coverage for auth and admin

tests/test_api.py bypasses authentication entirely. There is no test coverage for the JWT flow, meaning regressions in auth logic go undetected.

What to do

  • Add tests to tests/test_api.py (or a new tests/test_auth.py) covering:
    • User registration (success, duplicate username/email)
    • Login (success, wrong password, unknown user)
    • Accessing a protected route with a valid token
    • Accessing a protected route with an expired or invalid token (expect 401)
    • Token refresh
    • Admin-only endpoint access by a non-admin user (expect 403)
    • Admin-only endpoint access by an admin user (expect 200)
  • Use pytest fixtures for test users and tokens.

Acceptance criteria

  • All new tests pass with pytest.
  • Coverage for auth.py is at or above 80%.
  • CI runs these tests automatically.
## Context Roadmap item: P1 Test coverage for auth and admin `tests/test_api.py` bypasses authentication entirely. There is no test coverage for the JWT flow, meaning regressions in auth logic go undetected. ## What to do - Add tests to `tests/test_api.py` (or a new `tests/test_auth.py`) covering: - User registration (success, duplicate username/email) - Login (success, wrong password, unknown user) - Accessing a protected route with a valid token - Accessing a protected route with an expired or invalid token (expect 401) - Token refresh - Admin-only endpoint access by a non-admin user (expect 403) - Admin-only endpoint access by an admin user (expect 200) - Use pytest fixtures for test users and tokens. ## Acceptance criteria - All new tests pass with `pytest`. - Coverage for `auth.py` is at or above 80%. - CI runs these tests automatically.
AI-Manager added the P1agent-readymediumtest labels 2026-03-30 15:22:58 +00:00
AI-Manager commented 2026-03-30 16:05:30 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager] This issue has already been resolved on the main branch. Verified by code inspection during triage. Closing.

[Repo Manager] This issue has already been resolved on the main branch. Verified by code inspection during triage. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium test
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1356
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?