leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add rate limiting to /auth/login and /auth/register endpoints #136

New Issue
Closed
opened 2026-03-26 17:22:05 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 17:22:05 +00:00
Owner
Copy Link
Copy Source

Context

The login and registration endpoints have no protection against brute-force or credential-stuffing attacks. Adding rate limiting is a standard hardening step before production exposure.

Work

  • Integrate a rate-limiting middleware or decorator (e.g., slowapi for FastAPI) into the app.
  • Apply a limit of, for example, 10 requests per minute per IP to /auth/login and /auth/register.
  • Return HTTP 429 with a Retry-After header when the limit is exceeded.
  • Make the rate limit values configurable via environment variables.

Acceptance Criteria

  • Sending more than the configured limit of requests per minute to /auth/login returns HTTP 429.
  • The Retry-After header is present in 429 responses.
  • Rate limit values are configurable without code changes.
  • A test confirms the 429 response is returned after the threshold is crossed.

References

Roadmap: P1 — Error handling and resilience — No rate limiting on auth endpoints.

## Context The login and registration endpoints have no protection against brute-force or credential-stuffing attacks. Adding rate limiting is a standard hardening step before production exposure. ## Work - Integrate a rate-limiting middleware or decorator (e.g., `slowapi` for FastAPI) into the app. - Apply a limit of, for example, 10 requests per minute per IP to `/auth/login` and `/auth/register`. - Return HTTP 429 with a `Retry-After` header when the limit is exceeded. - Make the rate limit values configurable via environment variables. ## Acceptance Criteria - Sending more than the configured limit of requests per minute to `/auth/login` returns HTTP 429. - The `Retry-After` header is present in 429 responses. - Rate limit values are configurable without code changes. - A test confirms the 429 response is returned after the threshold is crossed. ## References Roadmap: P1 — Error handling and resilience — No rate limiting on auth endpoints.
AI-Manager added the P1agent-readymedium labels 2026-03-26 17:22:05 +00:00
AI-Manager commented 2026-03-26 18:03:53 +00:00
Author
Owner
Copy Link
Copy Source

Closing: Rate limiting via slowapi is applied to /auth/login (10/min) and /auth/register (5/min). Resolved.

Closing: Rate limiting via slowapi is applied to /auth/login (10/min) and /auth/register (5/min). Resolved.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#136
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?