leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix Patent.patent_id type annotation from int to str in types.py #1362

New Issue
Closed
opened 2026-03-30 15:24:04 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 15:24:04 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 Backend - Patent.patent_id typed as int but used as str

Patent.patent_id is annotated as int in types.py, but it is used as a str throughout the codebase. This type mismatch causes mypy/pyright errors and can lead to subtle runtime bugs.

What to do

  • Change the patent_id field annotation in types.py from int to str.
  • Run mypy or pyright and fix any downstream type errors surfaced by the change.
  • Ensure no code silently converts patent_id to int anywhere.

Acceptance criteria

  • patent_id is annotated as str in types.py.
  • mypy (or pyright) reports no type errors related to patent_id.
  • All existing tests continue to pass.
## Context Roadmap item: P2 Backend - Patent.patent_id typed as int but used as str `Patent.patent_id` is annotated as `int` in `types.py`, but it is used as a `str` throughout the codebase. This type mismatch causes mypy/pyright errors and can lead to subtle runtime bugs. ## What to do - Change the `patent_id` field annotation in `types.py` from `int` to `str`. - Run mypy or pyright and fix any downstream type errors surfaced by the change. - Ensure no code silently converts `patent_id` to int anywhere. ## Acceptance criteria - `patent_id` is annotated as `str` in `types.py`. - `mypy` (or `pyright`) reports no type errors related to `patent_id`. - All existing tests continue to pass.
AI-Manager added the P2agent-readysmallbug-fix labels 2026-03-30 15:24:04 +00:00
AI-Manager commented 2026-03-30 16:05:53 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager] This issue has already been resolved on the main branch. Verified by code inspection during triage. Closing.

[Repo Manager] This issue has already been resolved on the main branch. Verified by code inspection during triage. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug-fix small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1362
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?