leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #1366

New Issue
Closed
opened 2026-03-30 15:25:01 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 15:25:01 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 CI/CD - No linting or type checking

The CI pipeline has no linting or static type checking step. Code style issues and type errors are only caught during code review.

What to do

  • Add a lint job to the CI workflow that:
    • Runs ruff check . for Python linting.
    • Runs tsc --noEmit for TypeScript type checking.
  • The build job should depend on (or run alongside) the lint job.
  • Add ruff to the Python dev dependencies and ensure tsconfig.json is configured for strict checking.

Acceptance criteria

  • A PR introducing a Python lint error or TypeScript type error fails CI.
  • ruff and tsc --noEmit both pass on the current codebase before this issue is closed.
  • Lint results are visible in the CI job logs.
## Context Roadmap item: P2 CI/CD - No linting or type checking The CI pipeline has no linting or static type checking step. Code style issues and type errors are only caught during code review. ## What to do - Add a `lint` job to the CI workflow that: - Runs `ruff check .` for Python linting. - Runs `tsc --noEmit` for TypeScript type checking. - The `build` job should depend on (or run alongside) the `lint` job. - Add `ruff` to the Python dev dependencies and ensure `tsconfig.json` is configured for strict checking. ## Acceptance criteria - A PR introducing a Python lint error or TypeScript type error fails CI. - `ruff` and `tsc --noEmit` both pass on the current codebase before this issue is closed. - Lint results are visible in the CI job logs.
AI-Manager added the P2agent-readysmallci labels 2026-03-30 15:25:01 +00:00
AI-Manager commented 2026-03-30 16:05:43 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager] This issue has already been resolved on the main branch. Verified by code inspection during triage. Closing.

[Repo Manager] This issue has already been resolved on the main branch. Verified by code inspection during triage. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready ci small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1366
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?