leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add JWT authentication tests: registration, login, protected routes, admin endpoints #137

New Issue
Closed
opened 2026-03-26 17:22:15 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 17:22:15 +00:00
Owner
Copy Link
Copy Source

Context

The existing tests/test_api.py bypasses authentication entirely. There is no test coverage for the JWT flow, leaving login, registration, token refresh, and admin-only route enforcement untested.

Work

  • Add a tests/test_auth.py (or extend test_api.py) with test cases for:
    • Successful user registration
    • Duplicate registration rejected
    • Successful login returning a valid JWT
    • Invalid credentials rejected with HTTP 401
    • Accessing a protected route with a valid token succeeds
    • Accessing a protected route without a token returns HTTP 401
    • Token refresh flow (if implemented)
    • Admin-only endpoint rejected for non-admin users with HTTP 403
  • Use pytest fixtures for test user setup and teardown.

Acceptance Criteria

  • All listed scenarios have passing tests.
  • Tests do not rely on a live external service; database interactions use a test database or mocks.
  • pytest passes cleanly with the new tests.

References

Roadmap: P1 — Test coverage for auth and admin.

## Context The existing `tests/test_api.py` bypasses authentication entirely. There is no test coverage for the JWT flow, leaving login, registration, token refresh, and admin-only route enforcement untested. ## Work - Add a `tests/test_auth.py` (or extend `test_api.py`) with test cases for: - Successful user registration - Duplicate registration rejected - Successful login returning a valid JWT - Invalid credentials rejected with HTTP 401 - Accessing a protected route with a valid token succeeds - Accessing a protected route without a token returns HTTP 401 - Token refresh flow (if implemented) - Admin-only endpoint rejected for non-admin users with HTTP 403 - Use pytest fixtures for test user setup and teardown. ## Acceptance Criteria - All listed scenarios have passing tests. - Tests do not rely on a live external service; database interactions use a test database or mocks. - `pytest` passes cleanly with the new tests. ## References Roadmap: P1 — Test coverage for auth and admin.
AI-Manager added the P1agent-readymedium labels 2026-03-26 17:22:15 +00:00
AI-Manager commented 2026-03-26 18:03:52 +00:00
Author
Owner
Copy Link
Copy Source

Closing: Comprehensive JWT authentication test suite exists in tests/test_auth.py. Resolved via PR #35.

Closing: Comprehensive JWT authentication test suite exists in tests/test_auth.py. Resolved via PR #35.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#137
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?