leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add startup check to reject default JWT secret in non-dev environments #1375

New Issue
Closed
opened 2026-03-30 17:21:56 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 17:21:56 +00:00
Owner
Copy Link
Copy Source

Background

Roadmap item: P1 Security hardening — Rotate default JWT secret

auth.py ships a hardcoded fallback sparc-secret-key-change-in-production that is used when JWT_SECRET is unset. This means a misconfigured production deployment silently uses a publicly known secret, allowing token forgery.

Task

Add a startup guard in auth.py (or the FastAPI app startup event) that:

  1. Reads the JWT_SECRET environment variable.
  2. If the value equals the default string sparc-secret-key-change-in-production and the APP_ENV (or equivalent) is not development, raises a RuntimeError and refuses to start.
  3. If JWT_SECRET is unset entirely, raises a RuntimeError in all environments.

Acceptance Criteria

  • Application fails to start with a clear error message when JWT_SECRET is the default value outside of development mode.
  • Application starts normally when a non-default JWT_SECRET is provided.
  • A development environment bypasses the check (to keep local dev easy).
  • Existing unit tests still pass; a new test covers the startup check logic.
  • docker-compose.yml documents JWT_SECRET as a required variable with a comment.

Reference

See ROADMAP.md § P1 Security hardening.

## Background Roadmap item: **P1 Security hardening — Rotate default JWT secret** `auth.py` ships a hardcoded fallback `sparc-secret-key-change-in-production` that is used when `JWT_SECRET` is unset. This means a misconfigured production deployment silently uses a publicly known secret, allowing token forgery. ## Task Add a startup guard in `auth.py` (or the FastAPI app startup event) that: 1. Reads the `JWT_SECRET` environment variable. 2. If the value equals the default string `sparc-secret-key-change-in-production` **and** the `APP_ENV` (or equivalent) is not `development`, raises a `RuntimeError` and refuses to start. 3. If `JWT_SECRET` is unset entirely, raises a `RuntimeError` in all environments. ## Acceptance Criteria - [ ] Application fails to start with a clear error message when `JWT_SECRET` is the default value outside of `development` mode. - [ ] Application starts normally when a non-default `JWT_SECRET` is provided. - [ ] A `development` environment bypasses the check (to keep local dev easy). - [ ] Existing unit tests still pass; a new test covers the startup check logic. - [ ] `docker-compose.yml` documents `JWT_SECRET` as a required variable with a comment. ## Reference See ROADMAP.md § P1 Security hardening.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-30 17:21:56 +00:00
AI-Manager commented 2026-03-30 18:04:09 +00:00
Author
Owner
Copy Link
Copy Source

Resolved by PR #27 (merged). The check_jwt_secret() function in auth.py rejects the default JWT secret when APP_ENV is not development. Called during app lifespan startup.

Resolved by PR #27 (merged). The `check_jwt_secret()` function in `auth.py` rejects the default JWT secret when `APP_ENV` is not `development`. Called during app lifespan startup.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1375
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?