leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed-origins configurable via environment variable #1376

New Issue
Closed
opened 2026-03-30 17:22:11 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 17:22:11 +00:00
Owner
Copy Link
Copy Source

Background

Roadmap item: P1 Security hardening — CORS allow-origins are hardcoded

api.py hardcodes localhost:3000 and localhost:5173 as CORS origins. When SPARC is deployed behind a real domain the frontend cannot reach the API, or the origins must be widened to * (insecure).

Task

  1. Add a CORS_ORIGINS environment variable to config.py that accepts a comma-separated list of origins (e.g. https://sparc.example.com,https://sparc-staging.example.com).
  2. Fall back to ["http://localhost:3000", "http://localhost:5173"] when the variable is unset (preserves local-dev behaviour).
  3. Update the CORSMiddleware setup in api.py to read from the config value.
  4. Update docker-compose.yml with a commented-out CORS_ORIGINS example.

Acceptance Criteria

  • Setting CORS_ORIGINS=https://myapp.example.com in the environment causes the API to accept requests only from that origin.
  • Unsetting CORS_ORIGINS still allows localhost:3000 and localhost:5173.
  • No hardcoded origin strings remain in api.py.
  • Config documented in a .env.example or README.

Reference

See ROADMAP.md § P1 Security hardening.

## Background Roadmap item: **P1 Security hardening — CORS allow-origins are hardcoded** `api.py` hardcodes `localhost:3000` and `localhost:5173` as CORS origins. When SPARC is deployed behind a real domain the frontend cannot reach the API, or the origins must be widened to `*` (insecure). ## Task 1. Add a `CORS_ORIGINS` environment variable to `config.py` that accepts a comma-separated list of origins (e.g. `https://sparc.example.com,https://sparc-staging.example.com`). 2. Fall back to `["http://localhost:3000", "http://localhost:5173"]` when the variable is unset (preserves local-dev behaviour). 3. Update the `CORSMiddleware` setup in `api.py` to read from the config value. 4. Update `docker-compose.yml` with a commented-out `CORS_ORIGINS` example. ## Acceptance Criteria - [ ] Setting `CORS_ORIGINS=https://myapp.example.com` in the environment causes the API to accept requests only from that origin. - [ ] Unsetting `CORS_ORIGINS` still allows `localhost:3000` and `localhost:5173`. - [ ] No hardcoded origin strings remain in `api.py`. - [ ] Config documented in a `.env.example` or `README`. ## Reference See ROADMAP.md § P1 Security hardening.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-30 17:22:11 +00:00
AI-Manager commented 2026-03-30 18:04:12 +00:00
Author
Owner
Copy Link
Copy Source

Resolved by PR #27 (merged). CORS origins are now configurable via the CORS_ORIGINS environment variable in config.py, with sensible localhost defaults for development.

Resolved by PR #27 (merged). CORS origins are now configurable via the `CORS_ORIGINS` environment variable in `config.py`, with sensible localhost defaults for development.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1376
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?