leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Remove plain-text database credentials from docker-compose.yml #1377

New Issue
Closed
opened 2026-03-30 17:22:24 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 17:22:24 +00:00
Owner
Copy Link
Copy Source

Background

Roadmap item: P1 Security hardening — Database credentials in docker-compose.yml

docker-compose.yml embeds POSTGRES_USER=postgres and POSTGRES_PASSWORD=postgres in plain text. These values are committed to the repository and used verbatim in any environment that runs Compose, including CI and staging.

Task

  1. Create a .env.example file documenting all required environment variables including POSTGRES_USER, POSTGRES_PASSWORD, and POSTGRES_DB.
  2. Update docker-compose.yml to reference these via ${POSTGRES_PASSWORD} substitution syntax.
  3. Add .env to .gitignore (if not already present).
  4. Update the README with instructions for creating a local .env from .env.example.

Acceptance Criteria

  • docker-compose.yml contains no hardcoded credential values.
  • docker-compose up still works when a .env file with the variables is present.
  • .env is listed in .gitignore.
  • .env.example is committed and documents all required variables.
  • README explains the setup step.

Reference

See ROADMAP.md § P1 Security hardening.

## Background Roadmap item: **P1 Security hardening — Database credentials in docker-compose.yml** `docker-compose.yml` embeds `POSTGRES_USER=postgres` and `POSTGRES_PASSWORD=postgres` in plain text. These values are committed to the repository and used verbatim in any environment that runs Compose, including CI and staging. ## Task 1. Create a `.env.example` file documenting all required environment variables including `POSTGRES_USER`, `POSTGRES_PASSWORD`, and `POSTGRES_DB`. 2. Update `docker-compose.yml` to reference these via `${POSTGRES_PASSWORD}` substitution syntax. 3. Add `.env` to `.gitignore` (if not already present). 4. Update the README with instructions for creating a local `.env` from `.env.example`. ## Acceptance Criteria - [ ] `docker-compose.yml` contains no hardcoded credential values. - [ ] `docker-compose up` still works when a `.env` file with the variables is present. - [ ] `.env` is listed in `.gitignore`. - [ ] `.env.example` is committed and documents all required variables. - [ ] README explains the setup step. ## Reference See ROADMAP.md § P1 Security hardening.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-30 17:22:24 +00:00
AI-Manager commented 2026-03-30 18:04:14 +00:00
Author
Owner
Copy Link
Copy Source

Resolved by PR #27 (merged). All database credentials in docker-compose.yml now use environment variable interpolation (${POSTGRES_USER}, ${POSTGRES_PASSWORD}, ${POSTGRES_DB}). No plain-text credentials remain.

Resolved by PR #27 (merged). All database credentials in `docker-compose.yml` now use environment variable interpolation (`${POSTGRES_USER}`, `${POSTGRES_PASSWORD}`, `${POSTGRES_DB}`). No plain-text credentials remain.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1377
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?