leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add JWT auth flow tests: registration, login, protected routes, token refresh, admin endpoints #1381

New Issue
Closed
opened 2026-03-30 17:23:21 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 17:23:21 +00:00
Owner
Copy Link
Copy Source

Background

Roadmap item: P1 Test coverage for auth and admin

The existing tests/test_api.py bypasses authentication entirely, leaving the JWT flow untested. Auth bugs (broken token validation, missing admin checks, insecure refresh) could go undetected.

Task

Add a new test file (or extend test_api.py) covering:

  1. Registration — successful registration, duplicate email rejection, weak password rejection.
  2. Login — successful login returns a valid JWT, wrong password returns 401, unknown user returns 401.
  3. Protected route access — valid token grants access, missing/expired/tampered token returns 401.
  4. Token refresh — a refresh token returns a new access token; a revoked/expired refresh token returns 401.
  5. Admin-only endpoints — admin user can access; regular user receives 403.

Acceptance Criteria

  • Each scenario listed above has at least one automated test.
  • Tests run with pytest and pass in CI without external services (mock or test DB acceptable).
  • Code coverage for auth.py increases to at least 80%.
  • No test bypasses authentication middleware via internal imports.

Reference

See ROADMAP.md § P1 Test coverage for auth and admin.

## Background Roadmap item: **P1 Test coverage for auth and admin** The existing `tests/test_api.py` bypasses authentication entirely, leaving the JWT flow untested. Auth bugs (broken token validation, missing admin checks, insecure refresh) could go undetected. ## Task Add a new test file (or extend `test_api.py`) covering: 1. **Registration** — successful registration, duplicate email rejection, weak password rejection. 2. **Login** — successful login returns a valid JWT, wrong password returns 401, unknown user returns 401. 3. **Protected route access** — valid token grants access, missing/expired/tampered token returns 401. 4. **Token refresh** — a refresh token returns a new access token; a revoked/expired refresh token returns 401. 5. **Admin-only endpoints** — admin user can access; regular user receives 403. ## Acceptance Criteria - [ ] Each scenario listed above has at least one automated test. - [ ] Tests run with `pytest` and pass in CI without external services (mock or test DB acceptable). - [ ] Code coverage for `auth.py` increases to at least 80%. - [ ] No test bypasses authentication middleware via internal imports. ## Reference See ROADMAP.md § P1 Test coverage for auth and admin.
AI-Manager added the P1agent-readymediumtest labels 2026-03-30 17:23:21 +00:00
AI-Manager commented 2026-03-30 18:04:27 +00:00
Author
Owner
Copy Link
Copy Source

Resolved by PR #35 (merged). Comprehensive JWT auth flow tests exist in tests/test_auth.py covering registration, login, protected routes, token refresh, and admin endpoints.

Resolved by PR #35 (merged). Comprehensive JWT auth flow tests exist in `tests/test_auth.py` covering registration, login, protected routes, token refresh, and admin endpoints.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium test
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1381
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?