leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Replace print() calls with structured Python logging in analyzer, serp_api, and llm modules #1382

New Issue
Closed
opened 2026-03-30 17:23:40 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 17:23:40 +00:00
Owner
Copy Link
Copy Source

Background

Roadmap item: P2 Backend — Add structured logging

analyzer.py, serp_api.py, and llm.py use print() for diagnostics. This makes it impossible to filter log levels, redirect output to a log aggregator, or produce structured JSON logs for observability tooling.

Task

  1. Replace all print() calls in analyzer.py, serp_api.py, and llm.py with logging.getLogger(__name__) calls at appropriate levels (DEBUG, INFO, WARNING, ERROR).
  2. Configure a root logger in the app entry point with a configurable log level via LOG_LEVEL env var (default INFO).
  3. Optionally support JSON-formatted output via LOG_FORMAT=json env var (using python-json-logger or similar).
  4. Remove any remaining bare print() debug calls across the codebase.

Acceptance Criteria

  • No print() calls remain in analyzer.py, serp_api.py, or llm.py.
  • Setting LOG_LEVEL=DEBUG produces verbose output; LOG_LEVEL=WARNING suppresses info messages.
  • Log messages include module name, level, and timestamp.
  • Existing tests still pass.

Reference

See ROADMAP.md § P2 Backend.

## Background Roadmap item: **P2 Backend — Add structured logging** `analyzer.py`, `serp_api.py`, and `llm.py` use `print()` for diagnostics. This makes it impossible to filter log levels, redirect output to a log aggregator, or produce structured JSON logs for observability tooling. ## Task 1. Replace all `print()` calls in `analyzer.py`, `serp_api.py`, and `llm.py` with `logging.getLogger(__name__)` calls at appropriate levels (`DEBUG`, `INFO`, `WARNING`, `ERROR`). 2. Configure a root logger in the app entry point with a configurable log level via `LOG_LEVEL` env var (default `INFO`). 3. Optionally support JSON-formatted output via `LOG_FORMAT=json` env var (using `python-json-logger` or similar). 4. Remove any remaining bare `print()` debug calls across the codebase. ## Acceptance Criteria - [ ] No `print()` calls remain in `analyzer.py`, `serp_api.py`, or `llm.py`. - [ ] Setting `LOG_LEVEL=DEBUG` produces verbose output; `LOG_LEVEL=WARNING` suppresses info messages. - [ ] Log messages include module name, level, and timestamp. - [ ] Existing tests still pass. ## Reference See ROADMAP.md § P2 Backend.
AI-Manager added the P2agent-readysmallrefactor labels 2026-03-30 17:23:40 +00:00
AI-Manager commented 2026-03-30 18:04:48 +00:00
Author
Owner
Copy Link
Copy Source

Resolved by PRs #29 and #54 (merged). All print() calls in analyzer.py, serp_api.py, and llm.py have been replaced with structured Python logging. No bare print() calls remain in the SPARC package.

Resolved by PRs #29 and #54 (merged). All `print()` calls in `analyzer.py`, `serp_api.py`, and `llm.py` have been replaced with structured Python logging. No bare `print()` calls remain in the SPARC package.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready refactor small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1382
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?