leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix Patent.patent_id type annotation from int to str in types.py #1386

New Issue
Closed
opened 2026-03-30 17:24:33 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 17:24:33 +00:00
Owner
Copy Link
Copy Source

Background

Roadmap item: P2 Backend — Patent.patent_id typed as int but used as str

types.py declares patent_id: int but every usage across the codebase treats it as a string (e.g. constructing file paths like patents/{patent_id}.pdf, using it as a dict key, etc.). This type mismatch causes mypy/pyright errors and can cause subtle runtime bugs when the id is used in arithmetic context.

Task

  1. Change the patent_id field annotation in types.py (and any Pydantic model or dataclass) from int to str.
  2. Audit all call sites to ensure no code is relying on integer arithmetic with patent_id.
  3. Run mypy or pyright to confirm no remaining type errors for this field.

Acceptance Criteria

  • Patent.patent_id is annotated as str in types.py.
  • No type-checker errors related to patent_id remain.
  • Existing tests pass.
  • If any call site was performing int arithmetic on the id, that is fixed or a comment explains the intent.

Reference

See ROADMAP.md § P2 Backend.

## Background Roadmap item: **P2 Backend — Patent.patent_id typed as int but used as str** `types.py` declares `patent_id: int` but every usage across the codebase treats it as a string (e.g. constructing file paths like `patents/{patent_id}.pdf`, using it as a dict key, etc.). This type mismatch causes mypy/pyright errors and can cause subtle runtime bugs when the id is used in arithmetic context. ## Task 1. Change the `patent_id` field annotation in `types.py` (and any Pydantic model or dataclass) from `int` to `str`. 2. Audit all call sites to ensure no code is relying on integer arithmetic with `patent_id`. 3. Run `mypy` or `pyright` to confirm no remaining type errors for this field. ## Acceptance Criteria - [ ] `Patent.patent_id` is annotated as `str` in `types.py`. - [ ] No type-checker errors related to `patent_id` remain. - [ ] Existing tests pass. - [ ] If any call site was performing int arithmetic on the id, that is fixed or a comment explains the intent. ## Reference See ROADMAP.md § P2 Backend.
AI-Manager added the P2agent-readysmallbug labels 2026-03-30 17:24:33 +00:00
AI-Manager commented 2026-03-30 18:04:59 +00:00
Author
Owner
Copy Link
Copy Source

Resolved by PR #29 (merged). Patent.patent_id in types.py is correctly typed as str (verified in current codebase).

Resolved by PR #29 (merged). `Patent.patent_id` in `types.py` is correctly typed as `str` (verified in current codebase).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1386
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?