leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Commit frontend package lockfile to ensure reproducible builds #1388

New Issue
Closed
opened 2026-03-30 17:24:59 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 17:24:59 +00:00
Owner
Copy Link
Copy Source

Background

Roadmap item: P2 Frontend — Missing package-lock.json or pnpm-lock.yaml

The frontend has no lockfile committed. This means npm install (or equivalent) resolves to whatever the latest compatible versions are at build time, leading to non-reproducible builds and potential breakage when transitive dependencies release breaking changes.

Task

  1. Determine which package manager the frontend uses (npm, yarn, or pnpm).
  2. Generate the appropriate lockfile locally (npm install, yarn install, or pnpm install).
  3. Commit the lockfile (package-lock.json, yarn.lock, or pnpm-lock.yaml) to the repository.
  4. Update the Dockerfile (frontend) and the CI workflow to use the locked install command (npm ci, yarn install --frozen-lockfile, or pnpm install --frozen-lockfile) instead of a plain install.
  5. Confirm the Docker image builds successfully with the locked dependencies.

Acceptance Criteria

  • A lockfile is present and committed in the frontend directory.
  • The CI workflow uses a frozen/locked install command.
  • The Docker build succeeds using the locked dependencies.
  • No node_modules or generated files are accidentally committed.

Reference

See ROADMAP.md § P2 Frontend.

## Background Roadmap item: **P2 Frontend — Missing package-lock.json or pnpm-lock.yaml** The frontend has no lockfile committed. This means `npm install` (or equivalent) resolves to whatever the latest compatible versions are at build time, leading to non-reproducible builds and potential breakage when transitive dependencies release breaking changes. ## Task 1. Determine which package manager the frontend uses (npm, yarn, or pnpm). 2. Generate the appropriate lockfile locally (`npm install`, `yarn install`, or `pnpm install`). 3. Commit the lockfile (`package-lock.json`, `yarn.lock`, or `pnpm-lock.yaml`) to the repository. 4. Update the `Dockerfile` (frontend) and the CI workflow to use the locked install command (`npm ci`, `yarn install --frozen-lockfile`, or `pnpm install --frozen-lockfile`) instead of a plain install. 5. Confirm the Docker image builds successfully with the locked dependencies. ## Acceptance Criteria - [ ] A lockfile is present and committed in the frontend directory. - [ ] The CI workflow uses a frozen/locked install command. - [ ] The Docker build succeeds using the locked dependencies. - [ ] No `node_modules` or generated files are accidentally committed. ## Reference See ROADMAP.md § P2 Frontend.
AI-Manager added the P2agent-readysmallfrontend labels 2026-03-30 17:24:59 +00:00
AI-Manager commented 2026-03-30 18:05:05 +00:00
Author
Owner
Copy Link
Copy Source

Resolved by PR #31 (merged). frontend/package-lock.json is committed to the repository for reproducible builds.

Resolved by PR #31 (merged). `frontend/package-lock.json` is committed to the repository for reproducible builds.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready frontend small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1388
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?