leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refuse to start when default JWT secret is used in non-dev environments #1400

New Issue
Closed
opened 2026-03-30 18:21:40 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 18:21:40 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 -- Security hardening

auth.py ships a fallback secret sparc-secret-key-change-in-production that is used when the JWT_SECRET environment variable is unset. If this reaches a production deployment without being overridden, all tokens are trivially forgeable.

What to do

  • Add a startup check (e.g., in lifespan or at module import time) that inspects the resolved JWT secret value.
  • If the value matches the known default string AND the environment is not development (check a SPARC_ENV or APP_ENV env var), raise a RuntimeError or call sys.exit(1) with a clear message.
  • Document the required environment variables in README.md or a .env.example file.

Acceptance criteria

  • Starting the API with the default secret and APP_ENV=production causes an immediate, descriptive failure.
  • Starting with the default secret and APP_ENV=development (or unset) succeeds with a warning log.
  • Existing tests pass; a new test covers the rejection behaviour.
## Context Roadmap item: P1 -- Security hardening `auth.py` ships a fallback secret `sparc-secret-key-change-in-production` that is used when the `JWT_SECRET` environment variable is unset. If this reaches a production deployment without being overridden, all tokens are trivially forgeable. ## What to do - Add a startup check (e.g., in `lifespan` or at module import time) that inspects the resolved JWT secret value. - If the value matches the known default string AND the environment is not `development` (check a `SPARC_ENV` or `APP_ENV` env var), raise a `RuntimeError` or call `sys.exit(1)` with a clear message. - Document the required environment variables in `README.md` or a `.env.example` file. ## Acceptance criteria - [ ] Starting the API with the default secret and `APP_ENV=production` causes an immediate, descriptive failure. - [ ] Starting with the default secret and `APP_ENV=development` (or unset) succeeds with a warning log. - [ ] Existing tests pass; a new test covers the rejection behaviour.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-30 18:21:41 +00:00
AI-Manager commented 2026-03-30 19:04:40 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Already resolved in main.

check_jwt_secret() is implemented in SPARC/auth.py (lines 23-33) and called at startup in SPARC/api.py (line 181). Tests covering this behavior exist in tests/test_security.py. Closing as complete.

**Triage: Already resolved in main.** `check_jwt_secret()` is implemented in `SPARC/auth.py` (lines 23-33) and called at startup in `SPARC/api.py` (line 181). Tests covering this behavior exist in `tests/test_security.py`. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1400
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?