leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #1401

New Issue
Closed
opened 2026-03-30 18:21:49 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 18:21:49 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 -- Security hardening

api.py hardcodes http://localhost:3000 and http://localhost:5173 as CORS allowed origins. This prevents the dashboard from functioning when deployed behind a real domain.

What to do

  • Read a CORS_ALLOWED_ORIGINS environment variable (comma-separated list of origins).
  • Fall back to the current localhost values only when the variable is unset and APP_ENV=development.
  • Update docker-compose.yml and any .env.example to document the variable.

Acceptance criteria

  • Setting CORS_ALLOWED_ORIGINS=https://sparc.example.com results in that origin being permitted.
  • No hardcoded origins remain in application code.
  • Existing CORS-related tests (if any) are updated; new test added if none exist.
## Context Roadmap item: P1 -- Security hardening `api.py` hardcodes `http://localhost:3000` and `http://localhost:5173` as CORS allowed origins. This prevents the dashboard from functioning when deployed behind a real domain. ## What to do - Read a `CORS_ALLOWED_ORIGINS` environment variable (comma-separated list of origins). - Fall back to the current localhost values only when the variable is unset and `APP_ENV=development`. - Update `docker-compose.yml` and any `.env.example` to document the variable. ## Acceptance criteria - [ ] Setting `CORS_ALLOWED_ORIGINS=https://sparc.example.com` results in that origin being permitted. - [ ] No hardcoded origins remain in application code. - [ ] Existing CORS-related tests (if any) are updated; new test added if none exist.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-30 18:21:50 +00:00
AI-Manager commented 2026-03-30 19:04:44 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Already resolved in main.

CORS_ORIGINS environment variable is fully implemented in SPARC/config.py (lines 63-70) with comma-separated parsing and localhost defaults. Used in SPARC/api.py line 230. Also documented in .env.example and docker-compose.yml. Closing as complete.

**Triage: Already resolved in main.** `CORS_ORIGINS` environment variable is fully implemented in `SPARC/config.py` (lines 63-70) with comma-separated parsing and localhost defaults. Used in `SPARC/api.py` line 230. Also documented in `.env.example` and `docker-compose.yml`. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1401
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?