leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refactor get_db_client() in auth.py to use a shared connection pool #1403

New Issue
Closed
opened 2026-03-30 18:22:08 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 18:22:08 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 -- Error handling and resilience

get_db_client() in auth.py instantiates a new DatabaseClient on every invocation. Because FastAPI dependency injection calls this function per-request, each request opens its own connection, bypassing the connection pool and potentially exhausting the PostgreSQL max_connections limit under load.

What to do

  • Create a single module-level (or app-lifespan-scoped) DatabaseClient instance.
  • Convert get_db_client() to a FastAPI dependency that yields the shared client.
  • Ensure the client is properly closed on application shutdown via the lifespan context manager.
  • Verify no other module instantiates DatabaseClient outside of the shared instance.

Acceptance criteria

  • Only one DatabaseClient instance is created per application process.
  • Load testing with 20+ concurrent requests does not exhaust the DB connection pool.
  • Existing auth-related tests pass.
## Context Roadmap item: P1 -- Error handling and resilience `get_db_client()` in `auth.py` instantiates a new `DatabaseClient` on every invocation. Because FastAPI dependency injection calls this function per-request, each request opens its own connection, bypassing the connection pool and potentially exhausting the PostgreSQL `max_connections` limit under load. ## What to do - Create a single module-level (or app-lifespan-scoped) `DatabaseClient` instance. - Convert `get_db_client()` to a FastAPI dependency that yields the shared client. - Ensure the client is properly closed on application shutdown via the `lifespan` context manager. - Verify no other module instantiates `DatabaseClient` outside of the shared instance. ## Acceptance criteria - [ ] Only one `DatabaseClient` instance is created per application process. - [ ] Load testing with 20+ concurrent requests does not exhaust the DB connection pool. - [ ] Existing auth-related tests pass.
AI-Manager added the P1agent-readymediumrefactor labels 2026-03-30 18:22:08 +00:00
AI-Manager commented 2026-03-30 19:04:52 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Already resolved in main.

DatabaseClient in SPARC/database.py already uses psycopg2.pool.ThreadedConnectionPool (min=2, max=10) with a get_conn() context manager. get_db_client() in SPARC/auth.py uses a module-level singleton initialized at startup via init_db_client(). No per-request connection creation remains. Closing as complete.

**Triage: Already resolved in main.** `DatabaseClient` in `SPARC/database.py` already uses `psycopg2.pool.ThreadedConnectionPool` (min=2, max=10) with a `get_conn()` context manager. `get_db_client()` in `SPARC/auth.py` uses a module-level singleton initialized at startup via `init_db_client()`. No per-request connection creation remains. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium refactor
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1403
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?