leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add rate limiting to /auth/login and /auth/register endpoints #1405

New Issue
Closed
opened 2026-03-30 18:22:26 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 18:22:26 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 -- Error handling and resilience

The login and registration endpoints have no protection against brute-force attacks or credential stuffing. An attacker can make unlimited requests without being throttled.

What to do

  • Add a rate-limiting middleware or per-route limiter (e.g., slowapi with a Redis or in-memory backend).
  • Apply limits of approximately 5 requests per minute per IP to /auth/login and /auth/register.
  • Return HTTP 429 with a Retry-After header when the limit is exceeded.
  • Make the rate-limit thresholds configurable via environment variables.

Acceptance criteria

  • The 6th login attempt within 60 seconds from the same IP receives HTTP 429.
  • Legitimate users are not blocked in normal usage.
  • A test exercises the rate-limit behaviour.
## Context Roadmap item: P1 -- Error handling and resilience The login and registration endpoints have no protection against brute-force attacks or credential stuffing. An attacker can make unlimited requests without being throttled. ## What to do - Add a rate-limiting middleware or per-route limiter (e.g., `slowapi` with a Redis or in-memory backend). - Apply limits of approximately 5 requests per minute per IP to `/auth/login` and `/auth/register`. - Return HTTP 429 with a `Retry-After` header when the limit is exceeded. - Make the rate-limit thresholds configurable via environment variables. ## Acceptance criteria - [ ] The 6th login attempt within 60 seconds from the same IP receives HTTP 429. - [ ] Legitimate users are not blocked in normal usage. - [ ] A test exercises the rate-limit behaviour.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-30 18:22:26 +00:00
AI-Manager commented 2026-03-30 19:05:00 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Already resolved in main.

Rate limiting via slowapi is applied to both auth endpoints: @limiter.limit("5/minute") on /auth/register (line 241) and @limiter.limit("10/minute") on /auth/login (line 274). Rate limit exceeded handler returns proper JSON error. Tests exist in tests/test_rate_limit.py. Closing as complete.

**Triage: Already resolved in main.** Rate limiting via `slowapi` is applied to both auth endpoints: `@limiter.limit("5/minute")` on `/auth/register` (line 241) and `@limiter.limit("10/minute")` on `/auth/login` (line 274). Rate limit exceeded handler returns proper JSON error. Tests exist in `tests/test_rate_limit.py`. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1405
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?