leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add JWT authentication tests covering registration, login, and protected routes #1406

New Issue
Closed
opened 2026-03-30 18:22:36 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 18:22:36 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 -- Test coverage for auth and admin

The existing tests/test_api.py bypasses JWT authentication entirely. There are no tests that exercise the actual auth flow, leaving critical security logic untested.

What to do

Add a test file (e.g., tests/test_auth.py) that covers:

  • User registration: success, duplicate username/email rejection.
  • Login: valid credentials return a JWT; invalid credentials return 401.
  • Protected route access: valid token allows access; missing or expired token returns 401/403.
  • Token refresh: if a refresh endpoint exists, test it.
  • Admin-only endpoints: non-admin token is rejected with 403.

Acceptance criteria

  • All listed scenarios have at least one test case.
  • Tests run in CI without requiring external services (use test database or mocks).
  • pytest exits 0 with all new tests passing.
## Context Roadmap item: P1 -- Test coverage for auth and admin The existing `tests/test_api.py` bypasses JWT authentication entirely. There are no tests that exercise the actual auth flow, leaving critical security logic untested. ## What to do Add a test file (e.g., `tests/test_auth.py`) that covers: - User registration: success, duplicate username/email rejection. - Login: valid credentials return a JWT; invalid credentials return 401. - Protected route access: valid token allows access; missing or expired token returns 401/403. - Token refresh: if a refresh endpoint exists, test it. - Admin-only endpoints: non-admin token is rejected with 403. ## Acceptance criteria - [ ] All listed scenarios have at least one test case. - [ ] Tests run in CI without requiring external services (use test database or mocks). - [ ] `pytest` exits 0 with all new tests passing.
AI-Manager added the P1agent-readymediumtest labels 2026-03-30 18:22:36 +00:00
AI-Manager commented 2026-03-30 19:05:06 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Already resolved in main.

Comprehensive JWT auth tests exist in tests/test_auth.py covering: registration (first user admin, subsequent user, duplicate email), login (valid/invalid credentials), protected routes (/auth/me with valid/missing/expired/wrong-type tokens), token refresh (valid/invalid/wrong-type), and admin endpoints (list users, change role, self-role-change prevention, unauthorized access). 16 test cases total. Closing as complete.

**Triage: Already resolved in main.** Comprehensive JWT auth tests exist in `tests/test_auth.py` covering: registration (first user admin, subsequent user, duplicate email), login (valid/invalid credentials), protected routes (`/auth/me` with valid/missing/expired/wrong-type tokens), token refresh (valid/invalid/wrong-type), and admin endpoints (list users, change role, self-role-change prevention, unauthorized access). 16 test cases total. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium test
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1406
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?