leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix analyze_single_patent to download PDF before reading from disk #141

New Issue
Closed
opened 2026-03-26 17:22:47 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 17:22:47 +00:00
Owner
Copy Link
Copy Source

Context

analyze_single_patent constructs the path patents/{patent_id}.pdf and reads it directly, but does not trigger a download first. If the file is not already present the method fails silently or with a cryptic error.

Work

  • Audit the method to determine whether a download step is missing or whether the caller is responsible.
  • If the download step belongs in analyze_single_patent, integrate the existing download logic before the file read.
  • If the caller must download first, add a clear ValueError or FileNotFoundError with a helpful message explaining the prerequisite.
  • Add a docstring describing the precondition.
  • Add a test that confirms the appropriate behavior when the PDF is absent.

Acceptance Criteria

  • Calling analyze_single_patent with a patent ID that has no local PDF either (a) downloads the PDF automatically or (b) raises a clear, documented exception.
  • The fix is covered by a test.

References

Roadmap: P2 — Backend — analyze_single_patent assumes local file path.

## Context `analyze_single_patent` constructs the path `patents/{patent_id}.pdf` and reads it directly, but does not trigger a download first. If the file is not already present the method fails silently or with a cryptic error. ## Work - Audit the method to determine whether a download step is missing or whether the caller is responsible. - If the download step belongs in `analyze_single_patent`, integrate the existing download logic before the file read. - If the caller must download first, add a clear `ValueError` or `FileNotFoundError` with a helpful message explaining the prerequisite. - Add a docstring describing the precondition. - Add a test that confirms the appropriate behavior when the PDF is absent. ## Acceptance Criteria - Calling `analyze_single_patent` with a patent ID that has no local PDF either (a) downloads the PDF automatically or (b) raises a clear, documented exception. - The fix is covered by a test. ## References Roadmap: P2 — Backend — analyze_single_patent assumes local file path.
AI-Manager added the P2agent-readysmall labels 2026-03-26 17:22:47 +00:00
AI-Manager commented 2026-03-26 18:03:50 +00:00
Author
Owner
Copy Link
Copy Source

Closing: analyze_single_patent now auto-downloads PDFs from cached metadata links. Resolved via PR #55.

Closing: analyze_single_patent now auto-downloads PDFs from cached metadata links. Resolved via PR #55.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#141
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?