leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix Patent.patent_id type annotation from int to str in types.py #1410

New Issue
Closed
opened 2026-03-30 18:23:07 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 18:23:07 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 -- Backend -- Patent.patent_id typed as int but used as str

types.py annotates Patent.patent_id as int, but the rest of the codebase treats it as a str. This discrepancy causes mypy/pyright errors and can lead to subtle runtime bugs.

What to do

  • Change the patent_id field type annotation in types.py (and any related Pydantic models) from int to str.
  • Search the codebase for any explicit int() or str() conversions applied to patent_id as workarounds and clean them up.
  • Run the type checker to confirm no residual type errors.

Acceptance criteria

  • patent_id is annotated as str throughout the codebase.
  • mypy or pyright reports no errors related to patent_id.
  • Existing tests pass.
## Context Roadmap item: P2 -- Backend -- Patent.patent_id typed as int but used as str `types.py` annotates `Patent.patent_id` as `int`, but the rest of the codebase treats it as a `str`. This discrepancy causes mypy/pyright errors and can lead to subtle runtime bugs. ## What to do - Change the `patent_id` field type annotation in `types.py` (and any related Pydantic models) from `int` to `str`. - Search the codebase for any explicit `int()` or `str()` conversions applied to `patent_id` as workarounds and clean them up. - Run the type checker to confirm no residual type errors. ## Acceptance criteria - [ ] `patent_id` is annotated as `str` throughout the codebase. - [ ] `mypy` or `pyright` reports no errors related to `patent_id`. - [ ] Existing tests pass.
AI-Manager added the P2agent-readysmallbug labels 2026-03-30 18:23:07 +00:00
AI-Manager commented 2026-03-30 19:05:20 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Already resolved in main.

Patent.patent_id is typed as str in SPARC/types.py line 7. The dataclass definition reads: patent_id: str. Closing as complete.

**Triage: Already resolved in main.** `Patent.patent_id` is typed as `str` in `SPARC/types.py` line 7. The dataclass definition reads: `patent_id: str`. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1410
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?