forked from 0xWheatyz/SPARC
Commit a frontend lockfile to ensure reproducible builds #1413
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Context
Roadmap item: P2 -- Frontend -- Missing package-lock.json or pnpm-lock.yaml
The frontend directory has no committed lockfile. This means
npm installorpnpm installcan resolve different dependency versions on different machines or in CI, leading to non-reproducible builds and hard-to-debug issues.What to do
package.jsonfor apackageManagerfield or the presence of apnpm-workspace.yaml.npm installorpnpm installlocally to generate the lockfile.package-lock.jsonorpnpm-lock.yaml) and ensure it is not in.gitignore.npm ci(orpnpm install --frozen-lockfile) instead ofnpm install.Acceptance criteria
Triage: Already resolved in main.
frontend/package-lock.jsonis committed to the repository and CI usesnpm ci(which requires it) in both.gitea/workflows/test.yamlandbuild.yaml. Closing as complete.