leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #1415

New Issue
Closed
opened 2026-03-30 18:23:57 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 18:23:57 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 -- CI/CD -- No linting or type checking

There is no automated linting or type checking in CI. Style and type errors go undetected until review.

What to do

  • Add a lint job (or extend the test job) in the Gitea Actions workflow:
    • Python: pip install ruff && ruff check . (and optionally ruff format --check .).
    • TypeScript: tsc --noEmit from the frontend directory.
  • Create or update pyproject.toml with a [tool.ruff] section and tsconfig.json with strict settings if they don't already exist.
  • Fix any pre-existing lint/type errors that block CI (or use --ignore rules for known legacy issues and document them).

Acceptance criteria

  • ruff check . passes with zero errors on the current codebase (modulo documented ignores).
  • tsc --noEmit exits 0 on the current frontend codebase.
  • CI reports failure on a PR that introduces a new lint or type error.
## Context Roadmap item: P2 -- CI/CD -- No linting or type checking There is no automated linting or type checking in CI. Style and type errors go undetected until review. ## What to do - Add a `lint` job (or extend the `test` job) in the Gitea Actions workflow: - Python: `pip install ruff && ruff check .` (and optionally `ruff format --check .`). - TypeScript: `tsc --noEmit` from the frontend directory. - Create or update `pyproject.toml` with a `[tool.ruff]` section and `tsconfig.json` with strict settings if they don't already exist. - Fix any pre-existing lint/type errors that block CI (or use `--ignore` rules for known legacy issues and document them). ## Acceptance criteria - [ ] `ruff check .` passes with zero errors on the current codebase (modulo documented ignores). - [ ] `tsc --noEmit` exits 0 on the current frontend codebase. - [ ] CI reports failure on a PR that introduces a new lint or type error.
AI-Manager added the P2agent-readymediumci labels 2026-03-30 18:23:57 +00:00
AI-Manager commented 2026-03-30 19:05:41 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Already resolved in main.

Both linting steps exist in .gitea/workflows/test.yaml:

  • ruff: ruff check SPARC/ tests/ (lines 33-35)
  • tsc: npx tsc --noEmit (lines 55-56)

Also duplicated in build.yaml as a build gate. ruff.toml config file is present in the repo root. Closing as complete.

**Triage: Already resolved in main.** Both linting steps exist in `.gitea/workflows/test.yaml`: - **ruff**: `ruff check SPARC/ tests/` (lines 33-35) - **tsc**: `npx tsc --noEmit` (lines 55-56) Also duplicated in `build.yaml` as a build gate. `ruff.toml` config file is present in the repo root. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready ci medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1415
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?