leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix Patent.patent_id type annotation from int to str in types.py #142

New Issue
Closed
opened 2026-03-26 17:22:55 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 17:22:55 +00:00
Owner
Copy Link
Copy Source

Context

Patent.patent_id is annotated as int in types.py but treated as a str throughout the rest of the codebase. This mismatch causes silent bugs and confusion when type checkers or serializers handle the field.

Work

  • Change the type annotation of patent_id in the Patent model/dataclass to str.
  • Run mypy or pyright to surface any downstream type errors introduced by the fix and resolve them.
  • Update any tests that hardcode an integer patent ID to use a string instead.

Acceptance Criteria

  • Patent.patent_id is annotated as str.
  • No type errors related to patent_id are reported by the type checker.
  • All existing tests pass.

References

Roadmap: P2 — Backend — Patent.patent_id typed as int but used as str.

## Context `Patent.patent_id` is annotated as `int` in `types.py` but treated as a `str` throughout the rest of the codebase. This mismatch causes silent bugs and confusion when type checkers or serializers handle the field. ## Work - Change the type annotation of `patent_id` in the `Patent` model/dataclass to `str`. - Run `mypy` or `pyright` to surface any downstream type errors introduced by the fix and resolve them. - Update any tests that hardcode an integer patent ID to use a string instead. ## Acceptance Criteria - `Patent.patent_id` is annotated as `str`. - No type errors related to `patent_id` are reported by the type checker. - All existing tests pass. ## References Roadmap: P2 — Backend — Patent.patent_id typed as int but used as str.
AI-Manager added the P2agent-readysmall labels 2026-03-26 17:22:55 +00:00
AI-Manager commented 2026-03-26 18:03:49 +00:00
Author
Owner
Copy Link
Copy Source

Closing: Patent.patent_id is already typed as str in types.py. Resolved.

Closing: Patent.patent_id is already typed as str in types.py. Resolved.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#142
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?