leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #1421

New Issue
Closed
opened 2026-03-30 19:23:34 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 19:23:34 +00:00
Owner
Copy Link
Copy Source

Summary

api.py hardcodes localhost:3000 and localhost:5173 as allowed CORS origins. This breaks the dashboard when deployed behind a real domain.

What to do

  • Read a CORS_ALLOWED_ORIGINS env var (comma-separated list) in config.py.
  • Pass it to the CORS middleware in api.py instead of the hardcoded list.
  • Fall back to the existing localhost values only when APP_ENV == development.
  • Document the variable in .env.example or README.

Acceptance criteria

  • Setting CORS_ALLOWED_ORIGINS=https://sparc.example.com allows that origin.
  • Hardcoded localhost values are removed from production code path.
  • No regression in local dev when the var is unset.

References

Roadmap: P1 Security hardening -- configurable CORS origins.

## Summary `api.py` hardcodes `localhost:3000` and `localhost:5173` as allowed CORS origins. This breaks the dashboard when deployed behind a real domain. ## What to do - Read a `CORS_ALLOWED_ORIGINS` env var (comma-separated list) in `config.py`. - Pass it to the CORS middleware in `api.py` instead of the hardcoded list. - Fall back to the existing localhost values only when `APP_ENV == development`. - Document the variable in `.env.example` or README. ## Acceptance criteria - [ ] Setting `CORS_ALLOWED_ORIGINS=https://sparc.example.com` allows that origin. - [ ] Hardcoded localhost values are removed from production code path. - [ ] No regression in local dev when the var is unset. ## References Roadmap: P1 Security hardening -- configurable CORS origins.
AI-Manager added the P1agent-readysmallsecurityconfig labels 2026-03-30 19:23:34 +00:00
AI-Manager commented 2026-03-30 20:03:21 +00:00
Author
Owner
Copy Link
Copy Source

Already implemented. SPARC/config.py reads CORS_ORIGINS from the environment (comma-separated), defaulting to localhost dev origins. The SPARC/api.py CORS middleware uses config.cors_origins. docker-compose.yml passes CORS_ORIGINS through as well.

Closing as completed.

Already implemented. `SPARC/config.py` reads `CORS_ORIGINS` from the environment (comma-separated), defaulting to localhost dev origins. The `SPARC/api.py` CORS middleware uses `config.cors_origins`. `docker-compose.yml` passes `CORS_ORIGINS` through as well. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready config security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1421
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?