forked from 0xWheatyz/SPARC
Replace plain-text database credentials in docker-compose.yml with env file or secrets #1422
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
docker-compose.ymlembedspostgres:postgrescredentials in plain text. These should never be committed to source control.What to do
POSTGRES_USER/POSTGRES_PASSWORDvalues with references to a.envfile (viaenv_file:or${VAR}substitution)..envto.gitignoreand provide a.env.examplewith placeholder values.Acceptance criteria
docker-compose.ymlcontains no literal credential values..envis gitignored;.env.exampleis committed.docker compose upstill works when.envis populated.References
Roadmap: P1 Security hardening -- database credentials.
Already implemented.
docker-compose.ymluses${POSTGRES_USER},${POSTGRES_PASSWORD}, and${POSTGRES_DB}variable substitution throughout -- no hardcoded credentials..envis in.gitignoreand.env.exampleprovides placeholder values.Closing as completed.