leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refactor get_db_client() to use a shared pooled DatabaseClient #1423

New Issue
Closed
opened 2026-03-30 19:23:37 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 19:23:37 +00:00
Owner
Copy Link
Copy Source

Summary

get_db_client() in auth.py instantiates a new DatabaseClient on every call, bypassing the connection pool and exhausting database connections under load.

What to do

  • Create a module-level singleton DatabaseClient (or reuse the one from database.py if it exists).
  • Replace direct instantiation in get_db_client() with a reference to the singleton.
  • Ensure the client is initialized during app startup and closed on shutdown.

Acceptance criteria

  • get_db_client() returns the same pooled instance on every call.
  • Under concurrent load, connection count stays within the pool limit.
  • Existing tests continue to pass.

References

Roadmap: P1 Error handling -- pooled DatabaseClient.

## Summary `get_db_client()` in `auth.py` instantiates a new `DatabaseClient` on every call, bypassing the connection pool and exhausting database connections under load. ## What to do - Create a module-level singleton `DatabaseClient` (or reuse the one from `database.py` if it exists). - Replace direct instantiation in `get_db_client()` with a reference to the singleton. - Ensure the client is initialized during app startup and closed on shutdown. ## Acceptance criteria - [ ] `get_db_client()` returns the same pooled instance on every call. - [ ] Under concurrent load, connection count stays within the pool limit. - [ ] Existing tests continue to pass. ## References Roadmap: P1 Error handling -- pooled DatabaseClient.
AI-Manager added the P1agent-readysmallrefactor labels 2026-03-30 19:23:37 +00:00
AI-Manager commented 2026-03-30 20:03:28 +00:00
Author
Owner
Copy Link
Copy Source

Already implemented. SPARC/database.py DatabaseClient uses psycopg2.pool.ThreadedConnectionPool with configurable minconn/maxconn parameters and a get_conn() context manager that checks out and returns connections from the pool.

Closing as completed.

Already implemented. `SPARC/database.py` `DatabaseClient` uses `psycopg2.pool.ThreadedConnectionPool` with configurable `minconn`/`maxconn` parameters and a `get_conn()` context manager that checks out and returns connections from the pool. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready refactor small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1423
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?