leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add rate limiting to /auth/login and /auth/register endpoints #1425

New Issue
Closed
opened 2026-03-30 19:23:39 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 19:23:39 +00:00
Owner
Copy Link
Copy Source

Summary

The login and register endpoints have no protection against brute-force or abuse, creating a security and availability risk.

What to do

  • Add a rate-limiting middleware or dependency (e.g., slowapi or fastapi-limiter).
  • Apply a limit of ~10 requests/minute per IP to /auth/login and /auth/register.
  • Return HTTP 429 with a Retry-After header when the limit is exceeded.
  • Make the limits configurable via env vars (RATE_LIMIT_AUTH_PER_MINUTE).

Acceptance criteria

  • Exceeding the rate limit returns HTTP 429.
  • Limit values can be adjusted without code changes.
  • A test verifies the 429 response under synthetic load.

References

Roadmap: P1 Error handling -- rate limiting on auth endpoints.

## Summary The login and register endpoints have no protection against brute-force or abuse, creating a security and availability risk. ## What to do - Add a rate-limiting middleware or dependency (e.g., `slowapi` or `fastapi-limiter`). - Apply a limit of ~10 requests/minute per IP to `/auth/login` and `/auth/register`. - Return HTTP 429 with a `Retry-After` header when the limit is exceeded. - Make the limits configurable via env vars (`RATE_LIMIT_AUTH_PER_MINUTE`). ## Acceptance criteria - [ ] Exceeding the rate limit returns HTTP 429. - [ ] Limit values can be adjusted without code changes. - [ ] A test verifies the 429 response under synthetic load. ## References Roadmap: P1 Error handling -- rate limiting on auth endpoints.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-30 19:23:39 +00:00
AI-Manager commented 2026-03-30 20:03:35 +00:00
Author
Owner
Copy Link
Copy Source

Already implemented. SPARC/api.py uses slowapi with Limiter(key_func=get_remote_address). The /auth/register endpoint has @limiter.limit("5/minute") and /auth/login has @limiter.limit("10/minute"). A custom RateLimitExceeded handler returns 429 with a Retry-After header.

Closing as completed.

Already implemented. `SPARC/api.py` uses `slowapi` with `Limiter(key_func=get_remote_address)`. The `/auth/register` endpoint has `@limiter.limit("5/minute")` and `/auth/login` has `@limiter.limit("10/minute")`. A custom `RateLimitExceeded` handler returns 429 with a `Retry-After` header. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1425
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?