leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix analyze_single_patent to download PDF before reading from disk #1430

New Issue
Closed
opened 2026-03-30 19:23:47 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 19:23:47 +00:00
Owner
Copy Link
Copy Source

Summary

analyze_single_patent in the analyzer constructs a local path patents/{patent_id}.pdf and reads it, but never ensures the file has been downloaded first. Calling the method on a patent that has not been pre-fetched silently fails or raises a file-not-found error.

What to do

  • Before reading the file, check if it exists on disk.
  • If not present, call the download step to fetch and save the PDF.
  • Alternatively, clearly document the prerequisite and raise a descriptive error if the file is absent.

Acceptance criteria

  • Calling analyze_single_patent on a patent with no cached PDF either downloads it automatically or raises a clear FileNotFoundError with an actionable message.
  • A test covers both the cached and uncached paths.

References

Roadmap: P2 Backend -- analyze_single_patent PDF download.

## Summary `analyze_single_patent` in the analyzer constructs a local path `patents/{patent_id}.pdf` and reads it, but never ensures the file has been downloaded first. Calling the method on a patent that has not been pre-fetched silently fails or raises a file-not-found error. ## What to do - Before reading the file, check if it exists on disk. - If not present, call the download step to fetch and save the PDF. - Alternatively, clearly document the prerequisite and raise a descriptive error if the file is absent. ## Acceptance criteria - [ ] Calling `analyze_single_patent` on a patent with no cached PDF either downloads it automatically or raises a clear `FileNotFoundError` with an actionable message. - [ ] A test covers both the cached and uncached paths. ## References Roadmap: P2 Backend -- analyze_single_patent PDF download.
AI-Manager added the P2agent-readysmallbug labels 2026-03-30 19:23:47 +00:00
AI-Manager commented 2026-03-30 20:03:55 +00:00
Author
Owner
Copy Link
Copy Source

Already implemented. SPARC/analyzer.py analyze_single_patent() checks if the PDF exists on disk, and if not, looks up the cached PDF link via self.db.get_cached_patent(patent_id) and downloads it using SERP.save_patents() before proceeding with analysis. A clear FileNotFoundError is raised when no cached link is available.

Closing as completed.

Already implemented. `SPARC/analyzer.py` `analyze_single_patent()` checks if the PDF exists on disk, and if not, looks up the cached PDF link via `self.db.get_cached_patent(patent_id)` and downloads it using `SERP.save_patents()` before proceeding with analysis. A clear `FileNotFoundError` is raised when no cached link is available. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1430
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?