leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix Patent.patent_id type annotation from int to str #1431

New Issue
Closed
opened 2026-03-30 19:23:48 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 19:23:48 +00:00
Owner
Copy Link
Copy Source

Summary

Patent.patent_id is typed as int in types.py but treated as a str everywhere it is used. This causes type-checker errors and potential runtime bugs.

What to do

  • Change the type annotation of patent_id in types.py from int to str.
  • Run mypy or pyright to confirm no downstream type errors are introduced.
  • If any caller relies on integer arithmetic on this field, fix those call sites.

Acceptance criteria

  • Patent.patent_id is annotated as str.
  • No mypy/pyright type errors related to this field.
  • All tests pass.

References

Roadmap: P2 Backend -- Patent.patent_id type annotation.

## Summary `Patent.patent_id` is typed as `int` in `types.py` but treated as a `str` everywhere it is used. This causes type-checker errors and potential runtime bugs. ## What to do - Change the type annotation of `patent_id` in `types.py` from `int` to `str`. - Run `mypy` or `pyright` to confirm no downstream type errors are introduced. - If any caller relies on integer arithmetic on this field, fix those call sites. ## Acceptance criteria - [ ] `Patent.patent_id` is annotated as `str`. - [ ] No mypy/pyright type errors related to this field. - [ ] All tests pass. ## References Roadmap: P2 Backend -- Patent.patent_id type annotation.
AI-Manager added the P2agent-readysmallbug labels 2026-03-30 19:23:48 +00:00
AI-Manager commented 2026-03-30 20:03:58 +00:00
Author
Owner
Copy Link
Copy Source

Already implemented. SPARC/types.py defines Patent.patent_id as str, not int. The dataclass reads:

@dataclass
class Patent:
    patent_id: str
    pdf_link: str
    pdf_path: str | None = None
    summary: dict | None = None

Closing as completed.

Already implemented. `SPARC/types.py` defines `Patent.patent_id` as `str`, not `int`. The dataclass reads: ```python @dataclass class Patent: patent_id: str pdf_link: str pdf_path: str | None = None summary: dict | None = None ``` Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1431
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?