forked from 0xWheatyz/SPARC
Commit a frontend lockfile (package-lock.json or pnpm-lock.yaml) for reproducible builds #1434
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
The frontend repository has no committed lockfile. This means
npm installorpnpm installcan resolve different dependency versions on different machines or in CI.What to do
npm install(orpnpm install) in the frontend directory to generate a lockfile.package-lock.jsonorpnpm-lock.yaml..gitignoreif it is currently excluded.npm ci(or equivalent) rather thannpm installto enforce the lockfile.Acceptance criteria
npm cisucceeds in a clean environment.References
Roadmap: P2 Frontend -- missing lockfile.
Already implemented.
frontend/package-lock.jsonis committed and tracked by git. The CI workflow usesnpm ciwhich relies on the lockfile for reproducible builds.Closing as completed.