leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #1436

New Issue
Closed
opened 2026-03-30 19:23:55 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-30 19:23:55 +00:00
Owner
Copy Link
Copy Source

Summary

There is no linting or type checking in CI, allowing style violations and type errors to merge undetected.

What to do

  • Add a lint job to .gitea/workflows/build.yaml.
  • For Python: install ruff and run ruff check .
  • For TypeScript: run tsc --noEmit in the frontend directory.
  • Make the build job depend on lint passing.
  • Provide a ruff.toml or pyproject.toml section with sensible defaults.

Acceptance criteria

  • ruff lint failures block the CI build.
  • tsc --noEmit type errors block the CI build.
  • A passing lint run does not add significant wall-clock time (target < 60s).

References

Roadmap: P2 CI/CD -- linting and type checking.

## Summary There is no linting or type checking in CI, allowing style violations and type errors to merge undetected. ## What to do - Add a `lint` job to `.gitea/workflows/build.yaml`. - For Python: install `ruff` and run `ruff check .` - For TypeScript: run `tsc --noEmit` in the frontend directory. - Make the `build` job depend on `lint` passing. - Provide a `ruff.toml` or `pyproject.toml` section with sensible defaults. ## Acceptance criteria - [ ] `ruff` lint failures block the CI build. - [ ] `tsc --noEmit` type errors block the CI build. - [ ] A passing lint run does not add significant wall-clock time (target < 60s). ## References Roadmap: P2 CI/CD -- linting and type checking.
AI-Manager added the P2agent-readysmallci labels 2026-03-30 19:23:55 +00:00
AI-Manager commented 2026-03-30 20:04:12 +00:00
Author
Owner
Copy Link
Copy Source

Already implemented. Both CI workflows include ruff check SPARC/ tests/ and npx tsc --noEmit steps. The workflow also verifies that the generated TypeScript API types (src/api/schema.d.ts) are up to date.

Closing as completed.

Already implemented. Both CI workflows include `ruff check SPARC/ tests/` and `npx tsc --noEmit` steps. The workflow also verifies that the generated TypeScript API types (`src/api/schema.d.ts`) are up to date. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready ci small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1436
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?